hotcue activate position control returns wrong number for unset hotcue

[Kane Leja]

According to the documentation on the wiki http://www.mixxx.org/wiki/doku.php/mixxxcontrols, hotcue_X_position should give -1 if the hotcue is not set.

However, when I run it, I am getting -infinity when no track is loaded for the given deck, and -4.679544773884397e-8 if there is a track but the requested cue X is not set.

Version is Mixxx v1.11 beta 2 (is there a newer beta?)

[jus (jus)]

The latest builds can be found @ http://builds.mixxx.org/builds/release-1.11.x/

[Yoav Schatzberg (yschatzb)]

Hi all,

This is my first bug here with Mixxx. The description of the problem isn't very..well..descriptive for someone who has zero experience navigating the code base. I was wondering if there is some documentation/code examples/etc. that I should read before I dive into the code that will help me understand who does what and where it is located.

Also if anyone could just point me in the right direction to start looking, I would appreciate it :).

Thanks!

~Yoav

[Daniel Schürmann (daschuer)]

Hi Yoav,

thank you for adopting this bug. I think 1.12.0 is the right target version, because this is a "Low" importance bug.
So you should finally issue a merge request against https://github.com/mixxxdj/mixxx/master.

You find our doc at www.mixxx.org/wiki and inside the source code.
A good starting point is this: http://www.mixxx.org/wiki/doku.php/bugfix_workflow

The hotcues are handled here https://github.com/mixxxdj/mixxx/blob/7f9b662d17861359f955ce800e16ffce5d7c171e/src/engine/cuecontrol.cpp#L348

Kind regards,

Daniel

[Yoav Schatzberg (yschatzb)]

Hi Daniel,

Thank you for the information, however I am having trouble recreating the bug on the trunk branch.

I attempted the following to recreate it:
1) press hotcue button with no track loaded. (exited properly from hotcueActivate)
2) load track, then unload track and press hotcue button. (exited properly)
3) loaded track to deck and press button to assign hotcue. unload track and press hotcue button again (exited properly)

In no case was I able to cause getPosition() to return anything other than proper values. Am I missing something? please advise.

Thanks!

~Yoav

[Daniel Schürmann (daschuer)]

Thank you for checking this. I have no additional advice.
Maybe this bug was fixed accidentally or the bug was non.

@Kane Leja: can you confirm this bug still exist with latest builds on http://builds.mixxx.org/builds/trunk/
(Please backup your library folder ~/.mixxx first)
If it is still there, how we can reproduce it?
Thank you!

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6681