Mixxx

Waveform vsync test

Bug #1053141 reported by Daniel Schürmann on 2012-09-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mixxx	Fix Released	Low	Daniel Schürmann	Mixxx 2.0.0 "1.12.0"

Bug Description

Attached you will find a patch based on the mesa-demos glsync test.
It introduces a new waveform "GLVSyncTest" which toggle between red and white.

On my box I have awful flicker with the fglrx driver and better result with the radeon driver.

I have also noticed that the original glsync test flickers at the same moment the waveform flickers.

Related branches

lp:~daschuer/mixxx/daschuers_trunk

lp:~mixxxdevelopers/mixxx/waveform-dejerk

Ready for review for merging into lp:~mixxxdevelopers/mixxx/trunk

Mixxx Development Team: Pending requested 2013-04-03

Diff: 3371 lines (+1344/-530)

50 files modified

mixxx/build/depends.py (+4/-0)
mixxx/src/controlobjectbase.h (+147/-0)
mixxx/src/dlgprefcontrols.cpp (+16/-23)
mixxx/src/dlgprefcontrols.h (+1/-6)
mixxx/src/engine/bpmcontrol.cpp (+3/-2)
mixxx/src/engine/enginebuffer.cpp (+9/-10)
mixxx/src/engine/enginebuffer.h (+3/-2)
mixxx/src/main.cpp (+9/-0)
mixxx/src/mixxx.cpp (+1/-3)
mixxx/src/sounddeviceportaudio.cpp (+2/-0)
mixxx/src/visualplayposition.cpp (+109/-0)
mixxx/src/visualplayposition.h (+57/-0)
mixxx/src/waveform/renderers/glvsynctestrenderer.cpp (+133/-0)
mixxx/src/waveform/renderers/glvsynctestrenderer.h (+19/-0)
mixxx/src/waveform/renderers/waveformrenderbeat.cpp (+1/-1)
mixxx/src/waveform/renderers/waveformrendererendoftrack.cpp (+16/-2)
mixxx/src/waveform/renderers/waveformrendererendoftrack.h (+2/-1)
mixxx/src/waveform/renderers/waveformrendererhsv.cpp (+0/-177)
mixxx/src/waveform/renderers/waveformrendererhsv.h (+0/-21)
mixxx/src/waveform/renderers/waveformrendererpreroll.cpp (+5/-3)
mixxx/src/waveform/renderers/waveformrendermark.cpp (+2/-2)
mixxx/src/waveform/renderers/waveformrendermarkrange.cpp (+2/-2)
mixxx/src/waveform/renderers/waveformwidgetrenderer.cpp (+50/-50)
mixxx/src/waveform/renderers/waveformwidgetrenderer.h (+7/-4)
mixxx/src/waveform/vsyncthread.cpp (+179/-0)
mixxx/src/waveform/vsyncthread.h (+109/-0)
mixxx/src/waveform/waveformwidgetfactory.cpp (+160/-55)
mixxx/src/waveform/waveformwidgetfactory.h (+27/-16)
mixxx/src/waveform/widgets/emptywaveformwidget.cpp (+6/-0)
mixxx/src/waveform/widgets/emptywaveformwidget.h (+2/-1)
mixxx/src/waveform/widgets/glsimplewaveformwidget.cpp (+19/-4)
mixxx/src/waveform/widgets/glsimplewaveformwidget.h (+6/-5)
mixxx/src/waveform/widgets/glslwaveformwidget.cpp (+23/-3)
mixxx/src/waveform/widgets/glslwaveformwidget.h (+7/-5)
mixxx/src/waveform/widgets/glvsynctestwidget.cpp (+75/-0)
mixxx/src/waveform/widgets/glvsynctestwidget.h (+30/-0)
mixxx/src/waveform/widgets/glwaveformwidget.cpp (+18/-4)
mixxx/src/waveform/widgets/glwaveformwidget.h (+5/-4)
mixxx/src/waveform/widgets/hsvwaveformwidget.cpp (+0/-41)
mixxx/src/waveform/widgets/hsvwaveformwidget.h (+0/-29)
mixxx/src/waveform/widgets/qtsimplewaveformwidget.cpp (+19/-4)
mixxx/src/waveform/widgets/qtsimplewaveformwidget.h (+6/-5)
mixxx/src/waveform/widgets/qtwaveformwidget.cpp (+19/-4)
mixxx/src/waveform/widgets/qtwaveformwidget.h (+6/-5)
mixxx/src/waveform/widgets/softwarewaveformwidget.h (+5/-5)
mixxx/src/waveform/widgets/waveformwidgetabstract.cpp (+8/-15)
mixxx/src/waveform/widgets/waveformwidgetabstract.h (+5/-4)
mixxx/src/waveform/widgets/waveformwidgettype.h (+3/-2)
mixxx/src/widget/wspinny.cpp (+7/-8)
mixxx/src/widget/wspinny.h (+2/-2)

Revision history for this message

Daniel Schürmann (daschuer) wrote on 2012-09-19:

glvsynctestwidget.patch Edit (9.8 KiB, text/plain)

Changed in mixxx:
assignee:	nobody → Daniel Schürmann (daschuer)
status:	New → In Progress

Revision history for this message

Max Linke (max-linke) wrote on 2012-09-19: Re: [Bug 1053141] [NEW] Waveform vsync test

You mean between fglrx and the open source driver, I think it's called Gallium ? I wouldn't wonder if fglrx has problems since AMD does a bad job keeping their drivers working with the latest x version. I can test tomorrow if I see the same problem

Daniel Schürmann <email address hidden> wrote:

>Public bug reported:
>
>Attached you will find a patch based on the mesa-demos glsync test.
>It introduces a new waveform "GLVSyncTest" which toggle between red and white.
>
>On my box I have awful flicker with the fglrx driver and better result
>with the radeon driver.
>
>I have also noticed that the original glsync test flickers at the same
>moment the waveform flickers.
>
>** Affects: mixxx
> Importance: Undecided
> Assignee: Daniel Schürmann (daschuer)
> Status: In Progress
>
>--
>You received this bug notification because you are subscribed to Mixxx.
>Matching subscriptions: Mixxx-Bugs
>https://bugs.launchpad.net/bugs/1053141
>
>Title:
> Waveform vsync test
>
>Status in Mixxx:
> In Progress
>
>Bug description:
> Attached you will find a patch based on the mesa-demos glsync test.
> It introduces a new waveform "GLVSyncTest" which toggle between red and white.
>
> On my box I have awful flicker with the fglrx driver and better result
> with the radeon driver.
>
> I have also noticed that the original glsync test flickers at the same
> moment the waveform flickers.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/mixxx/+bug/1053141/+subscriptions

Revision history for this message

Daniel Schürmann (daschuer) wrote on 2012-09-20:

from the radeon man page:

Option "SwapbuffersWait" "boolean"
              This option controls the behavior of glXSwapBuffers and glXCopy‐
              SubBufferMESA calls by GL applications. If enabled, the calls
              will avoid tearing by making sure the display scanline is out‐
              side of the area to be copied before the copy occurs. If dis‐
              abled, no scanline synchronization is performed, meaning tearing
              will likely occur. Note that when enabled, this option can
              adversely affect the framerate of applications that render
              frames at less than refresh rate.

The default value is on.

Conclusion:
It is required that we sync the waveform frames somehow to the vertical blank
to a void an unpredictable delay of up to 16,6 ms @ 60 Hz Displays

Revision history for this message

jus (jus) wrote on 2013-12-14:

A vsync test waveform type is included an is available by starting Mixxx with --developer.
https://github.com/mixxxdj/mixxx/commit/de0e4a3787c3fee8f277520c0b33f7a3469adb87