support midi options in midi learn wizard

Bug #1022320 reported by Marco Sampellegrini
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
RJ Skerry-Ryan

Bug Description

Hi guys,

I'm trying mixxx 1.11 on ubuntu 12.04 with a korg nanokontrol. There is no mapping for this device so I gave the new midi learn a go. It works fine, all controllers are mapped correctly, but only sliders and knobs are actually working. Looking at the generated xml file, I can't see anything wrong and the mappings for buttons are present.

I tried deleting the .mixxx folder and doing the process again to no avail.

Thanks
Marco

Revision history for this message
jus (jus) wrote :

Launch Mixxx from the terminal with "mixxx --controllerDebug" causes the program to display/log all of the MIDI/HID/etc. messages it receives and script functions it loads. Could you try to check whether the messages it receives from the buttons from the nanocontrol are the ones in the xml?

Also there was this bug: https://bugs.launchpad.net/mixxx/+bug/995652
maybe your current 1.11 installation is affected, try to use the latest build.

Revision history for this message
Marco Sampellegrini (marko782) wrote :

I've compiled the latest version and got it working. The midi learn produces this code:

            <control>
                <group>[Channel1]</group>
                <key>play</key>
                <status>0xB0</status>
                <midino>0x21</midino>
                <options>
                    <normal/>
                </options>
            </control>

I had to change <normal/> to <button/> to make it work. Thanks for your help :)

Revision history for this message
jus (jus) wrote :

Excellent Marco,i am glad that it works now.
How is your 1.11 mapping different from the existing 1.8 mapping?
See http://mixxx.org/forums/viewtopic.php?f=7&t=1999&hilit=nano

Would you mind sharing your 1.11 mapping either here on launchpad.net or in the dedicated forum thread?

Revision history for this message
Marco Sampellegrini (marko782) wrote :

It's not that different. I'm still learning the inner workings of mixxx, especially the scripting engine which is just amazing. I'll sure post back something as soon as I'm satisfied with the result.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: none → 1.11.0
importance: Undecided → Medium
Revision history for this message
jus (jus) wrote :

Markin invalid, since the Point-and-Click-Midi Wizard works just fine.

We need to extend the functionality so one can change the midi Input tag options afterwards without diving into the xml code, similar to the Midi table what we had pre1.11.

Changed in mixxx:
status: New → Invalid
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

IMO not invalid since the point and click wizard won't work for devices like the NanoKontrol which need the <buton/> MIDI option. Ideally we could let them check a box or something or do a 'verify' step that if the verify fails we could try switching from normal to button.

Changed in mixxx:
status: Invalid → Confirmed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: 1.11.0 → 1.11.1
RJ Skerry-Ryan (rryan)
summary: - [midi learn] buttons not working
+ support midi options in midi learn wizard
Changed in mixxx:
milestone: 1.11.1 → none
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

While I believe the <button/> is no longer needed (thanks to Daniel's change to fix button handling), the midi learn wizard now supports setting MIDI options.

Changed in mixxx:
milestone: none → 1.12.0
status: Confirmed → Fix Committed
assignee: nobody → RJ Ryan (rryan)
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6567

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.