Only two decimal places allowed in the BPM-field in library grid when editing
Bug #1017376 reported by
Aleksandr Koltsoff
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
Low
|
Max Linke | ||
| 1.11 |
Won't Fix
|
Low
|
Max Linke | ||
| 2.0 |
Fix Released
|
Low
|
Max Linke | ||
Bug Description
When using the library grid to edit track metadata (please see attached screenshot), there's a restriction of only allowing two decimal places in the input widget.
Suggest raising this to at least 4 if there needs to be an arbitrary limit (2 is too little).
Tested on latest beta and verified on v1.11 r3287
Related branches
lp:~max-linke/mixxx/bpmdelegate
- Daniel Schürmann: Approve
-
Diff: 658 lines (+304/-9)32 files modifiedmixxx/build/depends.py (+2/-0)
mixxx/res/mixxx.qrc (+2/-0)
mixxx/res/skins/Deere1280x1024-SXGA/skin.xml (+3/-0)
mixxx/res/skins/Deere1280x800-WXGA/skin.xml (+4/-0)
mixxx/res/skins/Deere1366x768-WXGA/skin.xml (+3/-0)
mixxx/res/skins/Deere1440x900-WXGA+/skin.xml (+3/-0)
mixxx/res/skins/Deere1920x1080-FullHD/skin.xml (+3/-0)
mixxx/res/skins/Deere1920x1200-WUXGA/skin.xml (+3/-0)
mixxx/res/skins/DeereSamplegrid1280x800-WXGA/skin.xml (+3/-0)
mixxx/res/skins/LateNight1280x1024-SXGA/skin.xml (+3/-0)
mixxx/res/skins/LateNight1280x800-WXGA/skin.xml (+3/-0)
mixxx/res/skins/LateNight1366x768-WXGA/skin.xml (+3/-0)
mixxx/res/skins/LateNightBlues1280x1024-SXGA/skin.xml (+3/-0)
mixxx/res/skins/LateNightBlues1280x800-WXGA/skin.xml (+3/-0)
mixxx/res/skins/LateNightBlues1366x768-WXGA/skin.xml (+3/-0)
mixxx/res/skins/Phoney1600x1200-UXGA/skin.xml (+3/-0)
mixxx/res/skins/Phoney1680x1050-WSXGA/skin.xml (+3/-0)
mixxx/res/skins/PhoneyDark1600x1200-UXGA/skin.xml (+3/-0)
mixxx/res/skins/PhoneyDark1680x1050-WSXGA/skin.xml (+3/-0)
mixxx/res/skins/Shade1024x600-Netbook/skin.xml (+3/-0)
mixxx/res/skins/Shade1024x768-XGA/skin.xml (+3/-0)
mixxx/res/skins/ShadeDark1024x600-Netbook/skin.xml (+3/-0)
mixxx/res/skins/ShadeDark1024x768-XGA/skin.xml (+3/-0)
mixxx/src/library/basesqltablemodel.cpp (+3/-0)
mixxx/src/library/bpmdelegate.cpp (+75/-0)
mixxx/src/library/bpmdelegate.h (+39/-0)
mixxx/src/library/bpmeditor.cpp (+63/-0)
mixxx/src/library/bpmeditor.h (+33/-0)
mixxx/src/library/stardelegate.cpp (+0/-6)
mixxx/src/library/starrating.cpp (+1/-1)
mixxx/src/skin/legacyskinparser.cpp (+6/-1)
mixxx/src/widget/wtracktableview.cpp (+16/-1)
Revision history for this message
| Sean M. Pappalardo (pegasus-renegadetech) wrote | #2 |
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #3 |
| Changed in mixxx: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| Changed in mixxx: | |
| status: | Confirmed → Triaged |
Revision history for this message
| Max Linke (max-linke) wrote | #4 |
| Changed in mixxx: | |
| status: | Triaged → In Progress |
| Changed in mixxx: | |
| status: | In Progress → Fix Committed |
| assignee: | nobody → Max Linke (max-linke) |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #5 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
I tested this and the problem is in the library GUI. If you edit the track BPM in the properties dialog, the GUI shows 4 decimal places. So it's just the input widget code as the OP said.