Some buttons triggered from a MIDI controller don't light up on screen (or send MIDI output)

[Sean M. Pappalardo]

With MIDI buttons mapped to any of beatsync, cue_gotoandstop, cue_default, loop_in, loop_out, loop_halve and loop_double trigger the desired action when pressed but neither the GUI nor the controller buttons light up (using static XML <output> mappings.) When one of these is pressed on screen, it as well as the respective controller button light up correctly. The exceptions are play, flanger, pfl and hot cues; these all work correctly.

[Sean M. Pappalardo (pegasus-renegadetech)]

Fixed in trunk r3251. ControlPushButton was setting itself to the MIDI value instead of just toggling in one case.

[RJ Skerry-Ryan (rryan)]

I'm pretty sure your fix for this bug re-broke Bug #906310 (which is the change that got rid of the toggling).

[RJ Skerry-Ryan (rryan)]

Sorry -- I'm smoking something. This is unrelated to that change.

I'm not sure I agree this is the right way to fix this though. (I'm not sure I agree with that code as it was written anyway.. it should be set to 1 instead of v or !m_dValue).

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6501