Starrating is not shown for crates and other TableModels

Bug #1003566 reported by Max Linke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Max Linke

Bug Description

delegateForColumn is implemented in each TableModel and sometimes do different things although they should all have the same function.

As a solution we could declare delegateForColumn in BSTM.

Revision history for this message
Max Linke (max-linke) wrote :

This patch makes delegateForColumn a virtual function of BSTM and remove all implementations in derived TMs

Changed in mixxx:
status: New → Fix Committed
assignee: nobody → Max Linke (max-linke)
summary: - Starrating is not shown for crates and other tableModels
+ Starrating is not shown for crates and other TableModels
Max Linke (max-linke)
Changed in mixxx:
status: Fix Committed → In Progress
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Looks good -- thanks Max!

Changed in mixxx:
milestone: none → 1.11.0
importance: Undecided → Low
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6478

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.