Mistral doesn't use oslo_middleware.http_proxy_to_wsgi

Bug #1816364 reported by s10 on 2019-02-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Medium
s10

Bug Description

Mistral doesn't use oslo_middleware.http_proxy_to_wsgi.

If the passing of the forward headers (X-Forwarded-For, Host, X-Forwarded-Proto, X-Forwarded-Prefix) is enabled in https terminating proxy and proxy headers parsing is enabled in oslo_middleware, Mistral doesn't use this middleware.

mistral.conf:
[oslo_middleware]
enable_proxy_headers_parsing=True

curl https://api.example.com/workflowv2
{"versions": [{"status": "CURRENT", "id": "v2.0", "links": [{"href": "http://api.example.com/v2", "target": "v2", "rel": "self"}]}]}

s10 (vlad-esten) on 2019-02-18
description: updated
Changed in mistral:
milestone: none → stein-rc1
assignee: nobody → s10 (vlad-esten)
importance: Undecided → Medium
status: New → Confirmed

Reviewed: https://review.openstack.org/641649
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=ca1acb656cbd1ec30e327fa67cd9f6e75345b14f
Submitter: Zuul
Branch: master

commit ca1acb656cbd1ec30e327fa67cd9f6e75345b14f
Author: Vlad Gusev <email address hidden>
Date: Thu Mar 7 15:38:57 2019 +0300

    Add http_proxy_to_wsgi middleware

    This sets up the HTTPProxyToWSGI middleware in front of Mistral API. The
    purpose of this middleware is to set up the request URL correctly in
    the case there is a proxy (for instance, a loadbalancer such as HAProxy)
    in front of the Mistral API.

    The HTTPProxyToWSGI is off by default and needs to be enabled via a
    configuration value.

    It can be enabled with the option in mistral.conf:
    [oslo_middleware]
    enable_proxy_headers_parsing=True

    Closes-Bug: #1590608
    Closes-Bug: #1816364
    Change-Id: I04ba85488b27cb05c3b81ad8c973c3cc3fe56d36

Changed in mistral:
status: Confirmed → Fix Released

Reviewed: https://review.openstack.org/647694
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=8922940e0f7d5552462dd80b16cdffe9fb676c4e
Submitter: Zuul
Branch: stable/stein

commit 8922940e0f7d5552462dd80b16cdffe9fb676c4e
Author: Vlad Gusev <email address hidden>
Date: Thu Mar 7 15:38:57 2019 +0300

    Add http_proxy_to_wsgi middleware

    This sets up the HTTPProxyToWSGI middleware in front of Mistral API. The
    purpose of this middleware is to set up the request URL correctly in
    the case there is a proxy (for instance, a loadbalancer such as HAProxy)
    in front of the Mistral API.

    The HTTPProxyToWSGI is off by default and needs to be enabled via a
    configuration value.

    It can be enabled with the option in mistral.conf:
    [oslo_middleware]
    enable_proxy_headers_parsing=True

    Closes-Bug: #1590608
    Closes-Bug: #1816364
    Change-Id: I04ba85488b27cb05c3b81ad8c973c3cc3fe56d36
    (cherry picked from commit ca1acb656cbd1ec30e327fa67cd9f6e75345b14f)

tags: added: in-stable-stein

Reviewed: https://review.openstack.org/650990
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=6e05155c1df28cde9c42667faa5cf392d2c5b0ef
Submitter: Zuul
Branch: stable/rocky

commit 6e05155c1df28cde9c42667faa5cf392d2c5b0ef
Author: Vlad Gusev <email address hidden>
Date: Thu Mar 7 15:38:57 2019 +0300

    Add http_proxy_to_wsgi middleware

    This sets up the HTTPProxyToWSGI middleware in front of Mistral API. The
    purpose of this middleware is to set up the request URL correctly in
    the case there is a proxy (for instance, a loadbalancer such as HAProxy)
    in front of the Mistral API.

    The HTTPProxyToWSGI is off by default and needs to be enabled via a
    configuration value.

    It can be enabled with the option in mistral.conf:
    [oslo_middleware]
    enable_proxy_headers_parsing=True

    Closes-Bug: #1590608
    Closes-Bug: #1816364
    Change-Id: I04ba85488b27cb05c3b81ad8c973c3cc3fe56d36
    (cherry picked from commit ca1acb656cbd1ec30e327fa67cd9f6e75345b14f)

tags: added: in-stable-rocky

This issue was fixed in the openstack/mistral 9.0.0.0b1 development milestone.

This issue was fixed in the openstack/mistral 8.1.0 release.

This issue was fixed in the openstack/mistral 7.1.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers