Sometimes getting "DetachedInstanceError: Instance <ActionDefinition at..." when processing "on_action_complete"

[Renat Akhmerov]

Once in a while we get:

2018-11-11 22:35:56.891 12581 ERROR oslo_messaging.rpc.server [req-c95319cf-4a3e-49d4-9a43-1efda53a8b2b - CloudBandNetworkDirector - - -] Exception during message handling: DetachedInstanceError: Instance <ActionDefinition at 0x7fca0d61a050> is not bound to a Session; attribute refresh operation cannot proceed (Background on this error at: http://sqlalche.me/e/bhk3)

when Mistral processes an action.

This might be related with the action definition cache. If so, the solution is to clone objects before putting them into the cache.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/618133

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/618178

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/618133
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=90ddf442ee193d3b5b395d5f5a9aadb1dfe2b351
Submitter: Zuul
Branch: master

commit 90ddf442ee193d3b5b395d5f5a9aadb1dfe2b351
Author: Renat Akhmerov <email address hidden>
Date: Thu Nov 15 18:22:09 2018 +0700

    Clone cached action definitions

    * Once in a while we get DetachedInstanceError for action definitions
      and it happens when they are fetched from cache. We must always
      clone persistent objects before caching them.

    Change-Id: I1d0cffea6775eb258dcefc0dbb8a6ee18effe597
    Closes-Bug: #1803528

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/618178
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=9b302e2dc7270a74e77b6ef23c890b0016ab1371
Submitter: Zuul
Branch: stable/rocky

commit 9b302e2dc7270a74e77b6ef23c890b0016ab1371
Author: Renat Akhmerov <email address hidden>
Date: Thu Nov 15 18:22:09 2018 +0700

    Clone cached action definitions

    * Once in a while we get DetachedInstanceError for action definitions
      and it happens when they are fetched from cache. We must always
      clone persistent objects before caching them.

    Change-Id: I1d0cffea6775eb258dcefc0dbb8a6ee18effe597
    Closes-Bug: #1803528

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/mistral 8.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/mistral 7.1.0 release.