Integrity checker is too greedy

Bug #1801876 reported by Renat Akhmerov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
High
Renat Akhmerov

Bug Description

Workflow execution integrity checker may be too aggressive in case of a very big long running workflow. When a big workflow is running it may have many task executions in RUNNING state at the same time and the checker tries to process them all at once in a single transaction, so, in fact, it may block normal action completion processing for a significant period of time, even causing DB deadlocks (by timeout).

It makes sense to use batches when running this mechanism.

Changed in mistral:
assignee: nobody → Renat Akhmerov (rakhmerov)
milestone: none → stein-1
importance: Undecided → High
status: New → Confirmed
Changed in mistral:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/615720
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=3b4136ff1eb27472cb6d2ee4d1603e2b92f22ac9
Submitter: Zuul
Branch: master

commit 3b4136ff1eb27472cb6d2ee4d1603e2b92f22ac9
Author: Renat Akhmerov <email address hidden>
Date: Tue Nov 6 11:17:38 2018 +0700

    Add batch size for integrity checker

    * Added the new property 'execution_integrity_check_batch_size'
      under the [engine] group to limit the number of task executions
      that the integrity checker may process during one iteration.

    Closes-Bug: #1801876
    Change-Id: I3c5074c45c476ebff109617cb15d56c54575dd4f

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/617126

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/rocky)

Reviewed: https://review.openstack.org/617126
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=d8b19e93773a096d9eabc4d0427f8c061d2fa06f
Submitter: Zuul
Branch: stable/rocky

commit d8b19e93773a096d9eabc4d0427f8c061d2fa06f
Author: Renat Akhmerov <email address hidden>
Date: Tue Nov 6 11:17:38 2018 +0700

    Add batch size for integrity checker

    * Added the new property 'execution_integrity_check_batch_size'
      under the [engine] group to limit the number of task executions
      that the integrity checker may process during one iteration.

    Closes-Bug: #1801876
    Change-Id: I3c5074c45c476ebff109617cb15d56c54575dd4f
    (cherry picked from commit 3b4136ff1eb27472cb6d2ee4d1603e2b92f22ac9)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 8.0.0.0b1

This issue was fixed in the openstack/mistral 8.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 7.1.0

This issue was fixed in the openstack/mistral 7.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.