Task publish is ignored silently

Bug #1791449 reported by Vitalii Solodilov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Medium
ali abdelal

Bug Description

For instance, if a task has two publish attributes, a not "on-success" publish is silently ignored.
We should raise an exception during a workflow validation.

version: '2.0'
wf1:
    tasks:
      t1:
        publish:
          res_x1: 111
        on-success:
          next: t2
          publish:
            branch:
              res_x2: 222
      t2:
        action: std.noop
        publish:
          t2_x2: <% $.res_x2 %>
          t1_x1: <% $.res_x1 %>

mistral.exceptions.YaqlEvaluationException: Can not evaluate YAQL expression [expression=$.res_x1, error='res_x1', data={}]
] (execution_id=f32f00ac-c58e-4286-9c3b-6d4c52e854f9

description: updated
Dougal Matthews (d0ugal)
Changed in mistral:
status: New → Confirmed
importance: Undecided → Medium
Changed in mistral:
assignee: nobody → ali (alielal)
Changed in mistral:
milestone: none → train-1
Changed in mistral:
milestone: train-1 → train-rc1
Changed in mistral:
milestone: train-rc1 → train-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.opendev.org/686138

Changed in mistral:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on mistral (master)

Change abandoned by ali (<email address hidden>) on branch: master
Review: https://review.opendev.org/686138

Changed in mistral:
milestone: train-rc2 → ussuri-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.opendev.org/684711
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=c7a54d22df990795141dc990300ab76704aa5d30
Submitter: Zuul
Branch: master

commit c7a54d22df990795141dc990300ab76704aa5d30
Author: ali <email address hidden>
Date: Wed Sep 25 11:21:54 2019 +0000

    Task publish is ignored silently

    bug-fix, on-success, on complete published variables are not merged
     with regular published variables

    Closes-Bug: #1791449
    Change-Id: Iba05b9acbfea06214a3ab93911d2eaaa4729278f

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 10.0.0.0b1

This issue was fixed in the openstack/mistral 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.