Mistral HTTP action don't handle server error

Bug #1779973 reported by philo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Medium
Dougal Matthews

Bug Description

In action "std.mistral_http" have an odd behavior.

When my service returns HTTP code not in range(200, 307) it still in state RUNNING.
Cause of Mistral HTTP action implementation does not return the HTTP response result.

I have already fixed this bug: https://github.com/openstack/mistral/pull/8

Dougal Matthews (d0ugal)
Changed in mistral:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Dougal Matthews (d0ugal)
tags: added: low-hanging-fruit
Changed in mistral:
milestone: none → rocky-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/581059

Changed in mistral:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/581059
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=549ec1f3bfcaa0015cfcba8619cba3b09f5c54f9
Submitter: Zuul
Branch: master

commit 549ec1f3bfcaa0015cfcba8619cba3b09f5c54f9
Author: Dougal Matthews <email address hidden>
Date: Mon Jul 9 16:17:39 2018 +0100

    Return the result of the MistralHTTPAction

    If the HTTP request fails, we need to fail the task. Returning the error
    from the parent class will do this. While this means we also return the
    success result it will be ignored by the Mistral engine.

    Credit to @lijianying10 on GitHub for sending this fix via a pull
    request. Tests were then added to verify the change.

    Closes-Bug: #1779973
    Change-Id: Ib8754c8de2d6677d71383b3793d0fa168be575f5

Changed in mistral:
status: In Progress → Fix Released
Dougal Matthews (d0ugal)
tags: added: tripleo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 7.0.0.0b3

This issue was fixed in the openstack/mistral 7.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.