"__task_execution" of inbound task execution context is saved to DB

Bug #1764704 reported by Renat Akhmerov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
High
Renat Akhmerov

Bug Description

In order to implement YAQL/Jinja functin task() properly Mistral puts some internal data into task execution context. Specifically, the structure containing task id and name under the special key "__task_execution". This data should not be saved in DB because it's needed only for evaluating expressions. We should remove it before saving it to DB.

Changed in mistral:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Renat Akhmerov (rakhmerov)
milestone: none → rocky-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/561899

Changed in mistral:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/561899
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=6b7b58ed6c9dcad1a4db07586ea299bf01661523
Submitter: Zuul
Branch: master

commit 6b7b58ed6c9dcad1a4db07586ea299bf01661523
Author: Renat Akhmerov <email address hidden>
Date: Tue Apr 17 17:38:07 2018 +0700

    Add '__task_execution' structure to task execution context on the fly

    * Previously we stored the data structure describing the current
      task execution (id and name) in the inbound task execution context
      directly so that it'd be saved to DB. This was needed to evaluate
      YAQL/Jinja function task() without parameters properly. However,
      it's not needed, we can just build a context view on the fly
      just before evaluating an expression.

    Change-Id: If523039446ab3e2ccc9542617de2a170168f6e20
    Closes-Bug: #1764704

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 7.0.0.0b1

This issue was fixed in the openstack/mistral 7.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/562929

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/queens)

Reviewed: https://review.openstack.org/562929
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=2e027faf1e0082849fb45dc960ab32bcaa1bc4e0
Submitter: Zuul
Branch: stable/queens

commit 2e027faf1e0082849fb45dc960ab32bcaa1bc4e0
Author: Renat Akhmerov <email address hidden>
Date: Tue Apr 17 17:38:07 2018 +0700

    Add '__task_execution' structure to task execution context on the fly

    * Previously we stored the data structure describing the current
      task execution (id and name) in the inbound task execution context
      directly so that it'd be saved to DB. This was needed to evaluate
      YAQL/Jinja function task() without parameters properly. However,
      it's not needed, we can just build a context view on the fly
      just before evaluating an expression.

    Change-Id: If523039446ab3e2ccc9542617de2a170168f6e20
    Closes-Bug: #1764704
    (cherry picked from commit 6b7b58ed6c9dcad1a4db07586ea299bf01661523)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 6.0.2

This issue was fixed in the openstack/mistral 6.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/563863

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/pike)

Reviewed: https://review.openstack.org/563863
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=20248cc2a7b7dbd96e995f95e336f37bc9fb0eec
Submitter: Zuul
Branch: stable/pike

commit 20248cc2a7b7dbd96e995f95e336f37bc9fb0eec
Author: Renat Akhmerov <email address hidden>
Date: Tue Apr 17 17:38:07 2018 +0700

    Add '__task_execution' structure to task execution context on the fly

    * Previously we stored the data structure describing the current
      task execution (id and name) in the inbound task execution context
      directly so that it'd be saved to DB. This was needed to evaluate
      YAQL/Jinja function task() without parameters properly. However,
      it's not needed, we can just build a context view on the fly
      just before evaluating an expression.

    Closes-Bug: #1764704
    (cherry picked from commit 6b7b58ed6c9dcad1a4db07586ea299bf01661523)

    Change-Id: I9ea71cdc169c0c6f537429c75b5f1bd4079b87bf

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 5.2.3

This issue was fixed in the openstack/mistral 5.2.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.