Mistral

The string formatting in mistral.db.v2.sqlalchemy.api.update_on_match is invalid

Bug #1764696 reported by Dougal Matthews
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Critical
Dougal Matthews
Mistral rocky-1 "r1"

Bug Description

In https://github.com/openstack/mistral/blob/master/mistral/db/v2/sqlalchemy/api.py#L182-L184

The following error will happen, because we have "%," it should be "%s,"

ValueError: unsupported format character ',' (0x2c) at index 91

Dougal Matthews (d0ugal)
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/561853

Changed in mistral:
status: Confirmed → In Progress
Revision history for this message
Dougal Matthews (d0ugal) wrote :

This error was introduced here:

https://review.openstack.org/#/q/I546badd8b1c96b68567287fc9d38b07738272503

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/561853
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=15e95d9b3cc7ce8cbe8de22ef80e8230f22107ee
Submitter: Zuul
Branch: master

commit 15e95d9b3cc7ce8cbe8de22ef80e8230f22107ee
Author: Dougal Matthews <email address hidden>
Date: Tue Apr 17 10:31:55 2018 +0100

    Correct the string formatting in a info log message

    It should be "%s," not just "%,". The error observed was something
    like...

    ValueError: unsupported format character ',' (0x2c) at index 91

    Closes-Bug: #1764696
    Change-Id: I601c8640cec857746c2c17f94116da890f4d65e0

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/562045

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/562046

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/queens)

Reviewed: https://review.openstack.org/562045
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=48bdda8091b50a5d5f620aca16c58b5bec7ce45d
Submitter: Zuul
Branch: stable/queens

commit 48bdda8091b50a5d5f620aca16c58b5bec7ce45d
Author: Dougal Matthews <email address hidden>
Date: Tue Apr 17 10:31:55 2018 +0100

    Correct the string formatting in a info log message

    It should be "%s," not just "%,". The error observed was something
    like...

    ValueError: unsupported format character ',' (0x2c) at index 91

    Closes-Bug: #1764696
    Change-Id: I601c8640cec857746c2c17f94116da890f4d65e0
    (cherry picked from commit 15e95d9b3cc7ce8cbe8de22ef80e8230f22107ee)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 7.0.0.0b1

This issue was fixed in the openstack/mistral 7.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 6.0.2

This issue was fixed in the openstack/mistral 6.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/pike)

Reviewed: https://review.openstack.org/562046
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=b82abede8551887c1cc11114e3b6448891d92ed3
Submitter: Zuul
Branch: stable/pike

commit b82abede8551887c1cc11114e3b6448891d92ed3
Author: Dougal Matthews <email address hidden>
Date: Tue Apr 17 10:31:55 2018 +0100

    Correct the string formatting in a info log message

    It should be "%s," not just "%,". The error observed was something
    like...

    ValueError: unsupported format character ',' (0x2c) at index 91

    Closes-Bug: #1764696
    Change-Id: I601c8640cec857746c2c17f94116da890f4d65e0
    (cherry picked from commit 15e95d9b3cc7ce8cbe8de22ef80e8230f22107ee)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 5.2.3

This issue was fixed in the openstack/mistral 5.2.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.