Activity log for bug #1718353
| Date | Who | What changed | Old value | New value | Message |
|---|---|---|---|---|---|
| 2017-09-20 06:47:06 | Renat Akhmerov | bug | added bug | ||
| 2017-09-20 06:50:50 | Renat Akhmerov | description | The "context" parameter of Action.run() isn't filled properly for asynchronous actions. Asynchronous actions need things like "workflow_execution_id" but this parameter is just a MistralContext object that holds security info. I think we didn't fully account for that during "mistral-lib" related refactoring. So, "context" parameter, in my opinion, should be more structured so that we know what it contains. The suggestion is to create a class in mistral-lib called something like ActionContext that would look like: class ActionContext(object): def __init__(security_ctx, execution_ctx): ... class SecurityContext(object): # Same info as we have in MistralContext class.. class ExecutionContext(object): def __init__(workflow_execution_id, task_execution_id, ...) ... Once this is made we need to validate that pure asynchronous actions work properly (all contextual info is available) as well as ad-hoc actions built on top of them. | The "context" parameter of Action.run() isn't filled properly for asynchronous actions. Asynchronous actions need things like "workflow_execution_id" but this parameter is just a MistralContext object that holds security info which is in conflict with the description of this parameter (see [1]). I think we didn't fully account for that during "mistral-lib" related refactoring. So, "context" parameter, in my opinion, should be more structured so that we know what it contains. The suggestion is to create a class in mistral-lib called something like ActionContext that would look like: class ActionContext(object): def __init__(security_ctx, execution_ctx): ... class SecurityContext(object): # Same info as we have in MistralContext class.. class ExecutionContext(object): def __init__(workflow_execution_id, task_execution_id, ...) ... Once this is made we need to validate that pure asynchronous actions work properly (all contextual info is available) as well as ad-hoc actions built on top of them. See [2]. links: [1] https://github.com/openstack/mistral-lib/blob/master/mistral_lib/actions/base.py#L40 [2] https://github.com/openstack/mistral/blob/master/mistral/engine/actions.py#L338 | |
| 2017-09-20 06:50:52 | Renat Akhmerov | mistral: milestone | queens-1 | ||
| 2017-09-20 06:51:02 | Renat Akhmerov | mistral: assignee | Ryan Brady (rbrady) | ||
| 2017-09-20 06:51:04 | Renat Akhmerov | mistral: importance | Undecided | High | |
| 2017-09-20 06:51:07 | Renat Akhmerov | mistral: status | New | Confirmed | |
| 2017-09-20 06:54:05 | Renat Akhmerov | bug | added subscriber Moshe Elisha | ||
| 2017-09-20 08:31:03 | Dougal Matthews | tags | tripleo | ||
| 2017-09-20 08:31:28 | Dougal Matthews | mistral: assignee | Ryan Brady (rbrady) | Dougal Matthews (d0ugal) | |
| 2017-09-21 08:34:30 | OpenStack Infra | mistral: status | Confirmed | In Progress | |
| 2017-09-21 12:42:40 | Dougal Matthews | bug task added | tripleo | ||
| 2017-09-21 13:54:36 | Dougal Matthews | tripleo: importance | Undecided | Medium | |
| 2017-09-21 13:54:41 | Dougal Matthews | tripleo: assignee | Dougal Matthews (d0ugal) | ||
| 2017-09-21 13:55:44 | OpenStack Infra | tripleo: status | New | In Progress | |
| 2017-09-21 21:39:19 | Alex Schultz | tripleo: milestone | queens-1 | ||
| 2017-10-04 22:08:37 | Alex Schultz | tags | tripleo | tripleo workflows | |
| 2017-10-06 07:44:22 | OpenStack Infra | tags | tripleo workflows | in-stable-pike tripleo workflows | |
| 2017-10-23 16:10:44 | Emilien Macchi | tripleo: milestone | queens-1 | queens-2 | |
| 2017-11-16 08:35:48 | Renat Akhmerov | mistral: milestone | queens-1 | queens-2 | |
| 2017-12-05 00:20:45 | Alex Schultz | tripleo: milestone | queens-2 | queens-3 | |
| 2017-12-12 11:52:28 | Renat Akhmerov | mistral: milestone | queens-2 | queens-3 | |
| 2018-01-10 09:03:07 | OpenStack Infra | tripleo: assignee | Dougal Matthews (d0ugal) | Adriano Petrich (apetrich) | |
| 2018-01-10 10:54:44 | Dougal Matthews | mistral: status | In Progress | Fix Committed | |
| 2018-01-26 01:07:24 | Emilien Macchi | tripleo: milestone | queens-3 | queens-rc1 | |
| 2018-01-30 05:02:23 | Renat Akhmerov | mistral: milestone | queens-3 | queens-rc1 | |
| 2018-02-14 06:04:42 | Renat Akhmerov | mistral: status | Fix Committed | Fix Released | |
| 2018-02-20 22:26:07 | Alex Schultz | tripleo: milestone | queens-rc1 | rocky-1 | |
| 2018-04-02 13:36:06 | Brad P. Crochet | tripleo: status | In Progress | Fix Released | |
| 2018-04-02 13:38:16 | Brad P. Crochet | tripleo: status | Fix Released | In Progress | |
| 2018-04-02 16:23:05 | OpenStack Infra | tripleo: assignee | Adriano Petrich (apetrich) | Dougal Matthews (d0ugal) | |
| 2018-04-20 17:42:35 | Alex Schultz | tripleo: milestone | rocky-1 | rocky-2 | |
| 2018-06-05 00:38:52 | OpenStack Infra | tripleo: status | In Progress | Fix Released |
