A task should not be called 'fail', 'succeed', 'pause', 'noop'

Bug #1705186 reported by Xavier Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Medium
Hardik Jasani

Bug Description

It should not be possible to call a task `fail` since `fail` has become a keyword to trigger a workflow failure.

For instance, this will not call the task called `fail` but fail immediatly after init has been called.
```
version: '2.0'

the.bug:
    type: direct
    output:
        test_value: <% $.value %>

    tasks:
        init:
            publish:
                value: null
            on-success:
                - fail

        fail:
            action: std.fail
```

Tags: mistral ocata
summary: - A task should not be called 'fail'
+ A task should not be called 'fail', 'succeed', 'pause', 'noop'
Changed in mistral:
milestone: none → queens-1
importance: Undecided → Medium
assignee: nobody → noa (noa-koffman)
Revision history for this message
Renat Akhmerov (rakhmerov) wrote :

The same about "succeed", "pause" and "noop". They are also language keywords that are reserved for specific engine commands that change a workflow execution state directly.

Changed in mistral:
milestone: queens-1 → queens-2
Changed in mistral:
milestone: queens-2 → queens-3
Changed in mistral:
assignee: noa (noa-koffman) → Hardik Jasani (hjasani)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/535297

Changed in mistral:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/535297
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=b448f88c46cbdc7347d0f1132fb2d2a57c0ff513
Submitter: Zuul
Branch: master

commit b448f88c46cbdc7347d0f1132fb2d2a57c0ff513
Author: hardikj <email address hidden>
Date: Wed Jan 17 14:58:03 2018 +0530

    task name can not be reserved keyword

    Task name can not be one of the engine commands: noop, fail, pause, succeed.

    Change-Id: I4e92aba560daa3e045375a6728a7aee2b80473fc
    Closes-Bug: #1705186

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 6.0.0.0b3

This issue was fixed in the openstack/mistral 6.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.