Doc: explain various combinations of task names and workflow commands work in 'on-xxx' clauses

Bug #1682377 reported by Renat Akhmerov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
High
Renat Akhmerov

Bug Description

There maybe various combinations of task names and engine commands in 'on-success', 'on-error', 'on-complete'. For example,

taskA:
  action: ...
  on-success:
    - taskB
    - pause
    - taskC

or

taskA:
  action: ...
  on-success:
    - taskB
    - fail
    - taskC

We need to clearly explain how these combinations work in Mistral DSL spec and provide workflow examples illustrating that.

Changed in mistral:
milestone: none → pike-2
importance: Undecided → High
Changed in mistral:
assignee: nobody → Renat Akhmerov (rakhmerov)
Changed in mistral:
milestone: pike-2 → pike-3
Changed in mistral:
milestone: pike-3 → pike-rc1
Revision history for this message
Matt B (matty-brennan) wrote :

I believe I just ran in to this point of confusion. If a task has 'pause' and after the workflow gets there you set the workflow to "running", is it expected that the other on-success do not execute? This seems to be a different behavior than "pause-before"

Changed in mistral:
milestone: pike-rc1 → queens-1
Changed in mistral:
milestone: queens-1 → queens-2
Changed in mistral:
milestone: queens-2 → queens-3
Changed in mistral:
milestone: queens-3 → rocky-1
Revision history for this message
Renat Akhmerov (rakhmerov) wrote :

Matt, no, it's not expected. If it really behaves so then this is a bug.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/545692

Changed in mistral:
status: New → In Progress
Changed in mistral:
milestone: rocky-1 → rocky-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/545692
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=7423a58365c1c708f2231bfc7e4371bd220e75e5
Submitter: Zuul
Branch: master

commit 7423a58365c1c708f2231bfc7e4371bd220e75e5
Author: Renat Akhmerov <email address hidden>
Date: Mon Feb 12 15:40:55 2018 +0700

    Explain better combinations of task names and engine commands in docs

    Closes-Bug: #1682377
    Change-Id: I6c53fc6b3debaf27b01a03b5180f3ef56ddf3e8f

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/546557

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/queens)

Reviewed: https://review.openstack.org/546557
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=6d4766759e75427ae761a347fe20130f5133dac0
Submitter: Zuul
Branch: stable/queens

commit 6d4766759e75427ae761a347fe20130f5133dac0
Author: Renat Akhmerov <email address hidden>
Date: Mon Feb 12 15:40:55 2018 +0700

    Explain better combinations of task names and engine commands in docs

    Closes-Bug: #1682377
    Change-Id: I6c53fc6b3debaf27b01a03b5180f3ef56ddf3e8f
    (cherry picked from commit 7423a58365c1c708f2231bfc7e4371bd220e75e5)

tags: added: in-stable-queens
Changed in mistral:
milestone: rocky-rc2 → queens-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 6.0.1

This issue was fixed in the openstack/mistral 6.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 7.0.0.0b1

This issue was fixed in the openstack/mistral 7.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.