Workflow specification is parsed too many times

Bug #1541786 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Medium
Thomas Herve

Bug Description

During creation and execution, a single workflow can be parsed numerous times, most of the time uselessly. As it's fairly expensive, we should at least try to pass the parsed specification when we have it, instead of reparsing again.

Thomas Herve (therve)
Changed in mistral:
assignee: nobody → Thomas Herve (therve)
Changed in mistral:
status: New → In Progress
Changed in mistral:
importance: Undecided → Medium
milestone: none → mitaka-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/275372
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=65a84b469a349aa313c22eac27ecb8668a795623
Submitter: Jenkins
Branch: master

commit 65a84b469a349aa313c22eac27ecb8668a795623
Author: Thomas Herve <email address hidden>
Date: Tue Feb 2 18:31:37 2016 +0100

    Reduce spec parsing in workflow lifecycle

    During workflow creation and execution, its specification is parsed
    multiple times uselessly. This reduces the load by simply passing around
    the specification when it's available.

    Change-Id: I5babdbf8e9bc0cf7f69cf724bc7f6b0b270d1667
    Closes-Bug: #1541786

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/mistral 2.0.0.0b3

This issue was fixed in the openstack/mistral 2.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to mistral (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/292864

Lingxian Kong (kong)
Changed in mistral:
milestone: mitaka-3 → mitaka-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to mistral (master)

Reviewed: https://review.openstack.org/292864
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=1cdf79f44cd7539d2549e8f5297eb6780cd46b58
Submitter: Jenkins
Branch: master

commit 1cdf79f44cd7539d2549e8f5297eb6780cd46b58
Author: Thomas Herve <email address hidden>
Date: Tue Mar 15 13:51:23 2016 +0100

    Reduce spec parsing some more

    This removes even more parsing of specification, both for workflow and
    task, during a workflow execution.

    Related-Bug: #1541786
    Change-Id: Ib400308fabd6d62a061767956f4023b2b712e60f

Changed in mistral:
milestone: mitaka-rc1 → 2.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.