Define better terms for WAITING and DELAYED states

[Dmitri Zimine]

see here https://review.openstack.org/#/c/185532/12

[Renat Akhmerov (rakhmerov)]

So just to have all explanations at one place I'll summarize the semantical difference.

WAITING - workflow execution cursor already reached the task but it won't run until required triggering conditions are met. For "join" task the condition is completion of its inbound tasks. So the task may be hanging in this state forever.

DELAYED - This is basically a flavor of RUNNING state which means that task will eventually complete (with success or error), all triggering conditions are met. But the task is postponed for some period of time. Currently, this state is only needed for policies.

[Renat Akhmerov (rakhmerov)]

Possible renaming options:

1. WAITING -> UNDECIDED
    DELAYED -> DELAYED

2. WAITING -> WAITING
     DELAYED -> RUNNING_DELAYED

3. WAITING -> WAITING
     DELAYED -> POSTPONED

4. WAITING -> WAITING
     DELAYED -> DEFERRED (but IMO it's not any better)

5. WAITING -> WAITING
     DELAYED -> FUTURE (inspired by spiff workflow)

Any other suggestions?

[Lingxian Kong (kong)]

Hi, Renat, thanks for so many choices :-)

I prefer 1st one:
WAITING -> UNDECIDED
    DELAYED -> DELAYED

[Winson Chan (winson-c-chan)]

I prefer #3.
WAITING -> WAITING
DELAYED -> POSTPONED

UNDECIDED is not accurate. The join task knows how many inbound tasks succeeded and it made a decision and that is to wait.

[Renat Akhmerov (rakhmerov)]

Yes, for some reason I like renaming DELAYED to POSTPONED. It seems to have more precise meaning of being obliged to execute after some period of time. I may be wrong though since I'm not a native speaker.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/227728
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=3707062d67b8f8c51d5ee2aa6808793c81d81f5c
Submitter: Jenkins
Branch: master

commit 3707062d67b8f8c51d5ee2aa6808793c81d81f5c
Author: Renat Akhmerov <email address hidden>
Date: Fri Sep 25 15:07:28 2015 +0600

    Renaming state DELAYED to RUNNING_DELAYED

    * As discussed in the mailing list it's better to rename DELAYED
      to RUNNING_DELAYED so that we semantically express it as a substate
      of RUNNING whereas WAITING is not.

    Closes-Bug: #1470369
    Change-Id: I3b7033d894d29fe755d4d0262c1029c4576421cd

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/228354

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228354
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=b0cc7a4830fd807fb71c90e1d2b903ab975d3330
Submitter: Jenkins
Branch: master

commit b0cc7a4830fd807fb71c90e1d2b903ab975d3330
Author: Lingxian Kong <email address hidden>
Date: Mon Sep 28 16:27:32 2015 +0800

    Renaming state DELAYED to RUNNING_DELAYED in doc

    Please refer to https://review.openstack.org/#/c/227728/

    Change-Id: Iafe9e9949eb36a0df591e57ea3fae3d91634263a
    Related-Bug: #1470369

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/liberty
Review: https://review.openstack.org/233959

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233959
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=e3fe7ff10e871717c40b73e30eb07d4f8b055db0
Submitter: Jenkins
Branch: stable/liberty

commit e3fe7ff10e871717c40b73e30eb07d4f8b055db0
Author: Lingxian Kong <email address hidden>
Date: Mon Sep 28 16:27:32 2015 +0800

    Renaming state DELAYED to RUNNING_DELAYED in doc

    Please refer to https://review.openstack.org/#/c/227728/

    Change-Id: Iafe9e9949eb36a0df591e57ea3fae3d91634263a
    Related-Bug: #1470369
    (cherry picked from commit b0cc7a4830fd807fb71c90e1d2b903ab975d3330)