Double lock in force_close()

[Daniel d'Andrada]

WindowManagementPolicy::forceClose() is causing miral mutex to be locked twice in the same thread.

in qtmir:

void WindowManagementPolicy::forceClose(const miral::Window &window)
{
    m_tools.invoke_under_lock([&window, this]() {
        m_tools.force_close(window);
    });
}

------------------

in miral:

void miral::BasicWindowManager::force_close(Window const& window)
{
    auto application = window.application();

    if (application && window)
        remove_surface(application, window);
}

void miral::BasicWindowManager::remove_surface(...)
{
    Locker lock{mutex, policy};
    [...]
}

void miral::BasicWindowManager::invoke_under_lock(std::function<void()> const& callback)
{
    Locker lock{mutex, policy};
    callback();
}

[Alan Griffiths (alan-griffiths)]

Yes, force_close() expects the mutex to be locked and so shouldn't be calling a function from shell::WindowManager (because that locks the mutex).