Dialogs with parents should be modal i.e. they receive focus when the parent is clicked
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MirAL |
Fix Released
|
High
|
Alan Griffiths |
Bug Description
miral-shell --window-
Pull up the "About" window:
[2016-09-22 17:51:58.112692] miral::Window Management: place_new_surface app_info=
There we have a dialog with a parent.
Click on the parent:
Expected: the dialog retains (or gets) focus
Actual: The terminal window becomes active
[2016-09-22 18:00:28.242225] miral::Window Management: advise_begin
[2016-09-22 18:00:28.242367] <DEBUG> miral::Window Management: handle_
[2016-09-22 18:00:28.242412] miral::Window Management: window_at cursor=(436, 220) -> QTerminal
[2016-09-22 18:00:28.242506] miral::Window Management: advise_focus_lost window_
[2016-09-22 18:00:28.242552] miral::Window Management: advise_focus_gained window_
[2016-09-22 18:00:28.242569] miral::Window Management: raise_tree root=QTerminal
[2016-09-22 18:00:28.242596] miral::Window Management: advise_raise window_
[2016-09-22 18:00:28.242632] miral::Window Management: select_
The spec:
"If the surface has a child dialog, the deepest descendant dialog should receive input focus."
Related branches
- Gerry Boland (community): Approve
-
Diff: 197 lines (+121/-6)5 files modifiedmiral-shell/titlebar_window_manager.cpp (+4/-4)
miral/basic_window_manager.cpp (+9/-0)
test/CMakeLists.txt (+1/-0)
test/select_active_window.cpp (+99/-0)
test/test_window_manager_tools.h (+8/-2)
Changed in miral: | |
status: | New → Fix Committed |
importance: | Undecided → High |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
Changed in miral: | |
milestone: | none → 0.2 |
Changed in miral: | |
status: | Fix Committed → Fix Released |