MirAL

WindowManagerTools needs API for moving window corners

Bug #1623534 reported by Daniel d'Andrada
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MirAL
Won't Fix
Undecided
Unassigned

Bug Description

WindowManagerTools::modify_window() doesn't have enough context information to make the right decision when resizing a window from its top-left border, for instance.

When you resize a window from its top left corner (ie, move its top-left border), its bottom-right corner should remain still (ie x+width and y+height must not change). The bottom-right corner will move if you use WindowManagerTools::modify_window() for that and the window has a size increment set (of eg, 20 pixels). The bototm-right corner will jiggle in this case as miral complies with the position change but not with the size change.

We need a higher level API in WindowManagerTools than modify_window() to convey this information.

Related branches

lp:~alan-griffiths/miral/proof-of-concept-resize
Rejected for merging into lp:miral
Mir development team: Pending requested
Diff: 575 lines (+476/-6)
8 files modified
CMakeLists.txt (+1/-0)
include/miral/toolkit/surface_spec.h (+27/-0)
miral-client/CMakeLists.txt (+16/-0)
miral-client/client.cpp (+392/-0)
miral-shell/spinner/miregl.cpp (+3/-1)
miral-shell/spinner/miregl.h (+2/-0)
miral-shell/titlebar_window_manager.cpp (+34/-1)
miral/basic_window_manager.cpp (+1/-4)
lp:~dandrader/miral/move_window_corner
Rejected for merging into lp:miral
Alan Griffiths: Needs Information
Gerry Boland: Pending requested
Diff: 819 lines (+427/-51)
24 files modified
include/miral/types.h (+38/-0)
include/miral/window_manager_tools.h (+4/-0)
miral-qt/demos/qml-demo-shell/windowModel.qml (+82/-21)
miral-qt/src/common/mirqtconversion.h (+17/-0)
miral-qt/src/common/windowcontrollerinterface.h (+1/-0)
miral-qt/src/modules/Unity/Application/mirsurface.cpp (+7/-8)
miral-qt/src/modules/Unity/Application/mirsurface.h (+3/-1)
miral-qt/src/modules/Unity/Application/mirsurfaceinterface.h (+3/-0)
miral-qt/src/modules/Unity/Application/windowmodel.cpp (+0/-8)
miral-qt/src/modules/Unity/Application/windowmodel.h (+0/-1)
miral-qt/src/platforms/mirserver/windowcontroller.cpp (+8/-0)
miral-qt/src/platforms/mirserver/windowcontroller.h (+1/-0)
miral-qt/src/platforms/mirserver/windowmanagementpolicy.cpp (+7/-0)
miral-qt/src/platforms/mirserver/windowmanagementpolicy.h (+2/-0)
miral-qt/tests/framework/fake_mirsurface.h (+2/-0)
miral-qt/tests/framework/stub_windowcontroller.h (+1/-0)
miral/basic_window_manager.cpp (+97/-0)
miral/basic_window_manager.h (+2/-0)
miral/symbols.map (+1/-0)
miral/window_info.cpp (+12/-12)
miral/window_manager_tools.cpp (+3/-0)
miral/window_manager_tools_implementation.h (+2/-0)
test/CMakeLists.txt (+1/-0)
test/move_window_corner.cpp (+133/-0)
lp:~alan-griffiths/miral/BasicWindowManager-modify_window-doesnt-set-policy
Gerry Boland (community): Approve
Diff: 15 lines (+1/-4)
1 file modified
miral/basic_window_manager.cpp (+1/-4)
Daniel d'Andrada (dandrader)
Changed in miral:
assignee: nobody → Daniel d'Andrada (dandrader)
status: New → In Progress
Daniel d'Andrada (dandrader)
summary: - WindowManagerTools needs API for moving window borders
+ WindowManagerTools needs API for moving window corners
Daniel d'Andrada (dandrader)
Changed in miral:
status: In Progress → New
assignee: Daniel d'Andrada (dandrader) → nobody
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

BasicWindowManager::modify_window() shouldn't be calling constrain_resize() - that should be a policy decision.

I'm not sure that we currently want to "bake in" move_corner()/move_edge() or *any* other specific resize algorithm to BasicWindowManager

Changed in miral:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.