Keyboard modifiers (e.g. <shift> don't work for wayland clients
Bug #1718968 reported by
Alan Griffiths
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
High
|
Chris Halse Rogers |
Bug Description
Need to apply lp:~alan-griffiths/mir/fix-1718632 before keyboard input works at all
Related branches
lp:~raof/mir/fixish-wayland-keyboard
- Mir CI Bot: Needs Fixing (continuous-integration)
- Alan Griffiths: Approve
-
Diff: 942 lines (+249/-123)26 files modifiedexamples/miral-shell/decoration_provider.cpp (+2/-2)
include/core/mir/anonymous_shm_file.h (+8/-26)
include/core/mir/shm_file.h (+3/-9)
src/common/fd/CMakeLists.txt (+0/-1)
src/common/symbols.map (+0/-5)
src/core/CMakeLists.txt (+11/-0)
src/core/anonymous_shm_file.cpp (+42/-34)
src/core/symbols.map (+25/-1)
src/miral/application_authorizer.cpp (+1/-1)
src/platforms/common/server/CMakeLists.txt (+0/-2)
src/platforms/common/server/shm_buffer.cpp (+1/-1)
src/platforms/common/server/shm_buffer.h (+2/-1)
src/platforms/eglstream-kms/server/buffer_allocator.cpp (+2/-2)
src/platforms/eglstream-kms/server/software_buffer.cpp (+2/-2)
src/platforms/eglstream-kms/server/software_buffer.h (+3/-5)
src/platforms/mesa/server/buffer_allocator.cpp (+2/-2)
src/platforms/mesa/server/software_buffer.cpp (+2/-2)
src/platforms/mesa/server/software_buffer.h (+3/-5)
src/server/frontend/wayland/wayland_connector.cpp (+120/-3)
src/server/scene/basic_surface.cpp (+1/-1)
tests/mir_test_framework/stubbed_server_configuration.cpp (+3/-0)
tests/miral/window_properties.cpp (+4/-4)
tests/miral/workspaces.cpp (+3/-3)
tests/unit-tests/graphics/test_anonymous_shm_file.cpp (+4/-6)
tests/unit-tests/graphics/test_shm_buffer.cpp (+3/-3)
tests/unit-tests/platforms/mesa/kms/test_software_buffer.cpp (+2/-2)
lp:~mir-team/mir/fixish-wayland-keyboard
- Mir development team: Pending requested
lp:mir
- PS Jenkins bot (community): Approve (continuous-integration)
- Alan Griffiths: Approve
- Kevin DuBois (community): Approve
-
Diff: 1373 lines (+579/-161)23 files modified3rd_party/android-input/android/frameworks/base/services/input/MirLog.cpp (+157/-5)
include/test/mir_test_framework/display_server_test_fixture.h (+2/-0)
include/test/mir_test_framework/stub_client_connection_configuration.h (+35/-0)
include/test/mir_test_framework/testing_client_configuration.h (+43/-0)
include/test/mir_test_framework/testing_process_manager.h (+7/-8)
src/client/mir_client_library.cpp (+39/-17)
src/server/graphics/android/hwc_common_device.cpp (+15/-13)
src/server/options/program_option.cpp (+2/-1)
tests/acceptance-tests/test_client_authorization.cpp (+7/-0)
tests/acceptance-tests/test_client_focus_notification.cpp (+2/-9)
tests/acceptance-tests/test_client_input.cpp (+8/-15)
tests/acceptance-tests/test_client_library.cpp (+30/-17)
tests/acceptance-tests/test_focus_selection.cpp (+2/-9)
tests/acceptance-tests/test_server_shutdown.cpp (+2/-9)
tests/acceptance-tests/test_shell_control_of_surface_configuration.cpp (+2/-9)
tests/acceptance-tests/test_surfaceloop.cpp (+3/-10)
tests/acceptance-tests/test_surfaces_with_output_id.cpp (+2/-9)
tests/mir_test_framework/CMakeLists.txt (+1/-0)
tests/mir_test_framework/display_server_test_fixture.cpp (+9/-6)
tests/mir_test_framework/testing_client_options.cpp (+126/-0)
tests/mir_test_framework/testing_process_manager.cpp (+41/-1)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+25/-1)
tests/unit-tests/logging/test_legacy_input_report.cpp (+19/-22)
tags: | added: wayland |
Changed in mir: | |
status: | Triaged → In Progress |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
Changed in mir: | |
assignee: | Alan Griffiths (alan-griffiths) → nobody |
Changed in mir: | |
assignee: | nobody → Chris Halse Rogers (raof) |
status: | In Progress → Fix Committed |
Changed in mir: | |
status: | Fix Committed → In Progress |
Changed in mir: | |
status: | In Progress → Fix Committed |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is because wl_keyboard_ send_modifiers( ) isn't being called.