[regression] mir_demo_server refuses to quit on Ctrl+Alt+Backspace or Ctrl+C in its terminal (deadlock in DefaultInputDeviceHub::add_device)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
High
|
Alan Griffiths | ||
0.26 |
Invalid
|
High
|
Unassigned | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
mir_demo_server refuses to quit on Ctrl+Alt+Backspace
It knows it should be quitting but doesn't, even when I try multiple times:
[2017-02-02 12:13:12.670302] mirserver: Stopping
[2017-02-02 12:13:13.070166] mirserver: Stopping
[2017-02-02 12:13:13.302165] mirserver: Stopping
[2017-02-02 12:13:13.510186] mirserver: Stopping
[2017-02-02 12:13:13.686165] mirserver: Stopping
[2017-02-02 12:13:13.870160] mirserver: Stopping
[2017-02-02 12:13:14.062330] mirserver: Stopping
[2017-02-02 12:13:14.254349] mirserver: Stopping
[2017-02-02 12:13:14.438335] mirserver: Stopping
[2017-02-02 12:13:14.622329] mirserver: Stopping
[2017-02-02 12:13:14.830312] mirserver: Stopping
Similarly, Ctrl+C no longer works:
[2017-02-10 11:16:18.643952] mirserver: Logical position +0+0
[2017-02-10 11:16:18.643955] mirserver: Output 52: HDMI-A disconnected
^C^C^C^
Related branches
- Andreas Pokorny (community): Approve
- Alan Griffiths: Abstain
- Daniel van Vugt: Approve (manual testing)
- Mir CI Bot: Approve (continuous-integration)
-
Diff: 207 lines (+68/-50)2 files modifiedsrc/server/input/default_input_device_hub.cpp (+65/-48)
src/server/input/default_input_device_hub.h (+3/-2)
Changed in mir: | |
importance: | Undecided → Medium |
Changed in mir: | |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
Changed in mir (Ubuntu): | |
status: | New → Invalid |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Bisected. The regression started here:
------- ------- ------- ------- ------- ------- ------- ------- ---- n_apply_ input_configura tion and mir_connection_ set_base_ input_configura tion
revno: 4002 [merge]
author: Andreas Pokorny <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Wed 2017-02-01 17:32:36 +0000
message:
mir_connectio
This adds two new mirclient functions to configure input devices. The base input configuration behaves like the base display configuration.
.
Approved by Alan Griffiths, mir-ci-bot. ------- ------- ------- ------- ------- ------- ------- ----
-------