i386 FTBFS: src/platforms/eglstream-kms/server/kms_display_configuration.cpp:88:47: error: narrowing conversion of ‘..._drmModeConnector::connector_id’ from ‘uint32_t {aka unsigned int}’ to ‘EGLAttrib {aka int}’ inside { } [-Werror=narrowing]

Bug #1656633 reported by Daniel van Vugt
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Daniel van Vugt
mir (Ubuntu)
Fix Released

Bug Description

lp:mir fails to build on zesty i386:

/home/dan/bzr/mir/trunk/src/platforms/eglstream-kms/server/kms_display_configuration.cpp: In function ‘std::vector<std::shared_ptr<mir::graphics::eglstream::kms::EGLOutput> > {anonymous}::create_outputs(int, EGLDisplay)’:
/home/dan/bzr/mir/trunk/src/platforms/eglstream-kms/server/kms_display_configuration.cpp:88:47: error: narrowing conversion of ‘(& connector)->std::unique_ptr<_Tp, _Dp>::operator-><_drmModeConnector, std::function<void(_drmModeConnector*)> >()->_drmModeConnector::connector_id’ from ‘uint32_t {aka unsigned int}’ to ‘EGLAttrib {aka int}’ inside { } [-Werror=narrowing]
             EGL_DRM_CONNECTOR_EXT, connector->connector_id,

Related branches

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I guess we didn't notice because the eglstream-kms platform isn't built in CI yet (LP: #1607358)

Changed in mir:
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → Daniel van Vugt (vanvugt)
milestone: none → 0.26.0
Changed in mir:
milestone: 0.26.0 → 1.0.0
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 1.0.0

Changed in mir:
status: In Progress → Fix Committed
Changed in mir:
milestone: 1.0.0 → 0.26.0
summary: i386 FTBFS: src/platforms/eglstream-
kms/server/kms_display_configuration.cpp:88:47: error: narrowing
- conversion of ‘(& connector)->std::unique_ptr<_Tp,
- _Dp>::operator-><_drmModeConnector,
- std::function<void(_drmModeConnector*)>
- >()->_drmModeConnector::connector_id’ from ‘uint32_t {aka unsigned int}’
- to ‘EGLAttrib {aka int}’ inside { } [-Werror=narrowing]
+ conversion of ‘..._drmModeConnector::connector_id’ from ‘uint32_t {aka
+ unsigned int}’ to ‘EGLAttrib {aka int}’ inside { } [-Werror=narrowing]
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (7.2 KiB)

This bug was fixed in the package mir - 0.26.0+17.04.20170126.3-0ubuntu1

mir (0.26.0+17.04.20170126.3-0ubuntu1) zesty; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.26.0 (https://launchpad.net/mir/+milestone/0.26.0)
    - ABI summary:
      . mirclient ABI unchanged at 9
      . mirserver ABI bumped to 43
      . mircommon ABI unchanged at 7
      . mirplatform ABI unchanged at 14
      . mirprotobuf ABI unchanged at 3
      . mirplatformgraphics ABI unchanged at 11
      . mirclientplatform ABI unchanged at 5
      . mirinputplatform ABI unchanged at 6
      . mircore ABI unchanged at 1
    - Enhancements:
      . New/improved toolkit APIs: MirInputConfig and related functions,
        MirWindow and related functions, DisplayConfig and related functions,
        MirScreencastSpec and related functions,
      . Support for configuring input configuration
      . Introduce toolkit extension mechanism for platform specific APIs.
      . Toolkit extensions for: mesa_drm_auth, set_gbm_device and
      . Screencasting to a specific MirBuffer.
      . Add DisplayConfigurationController::base_configuration() so downstreams
        can get the base configuration. (Weirdly they can already set it.).
      . x11 platform: allow adjustable scale parameter.
      . Added EDID support: client API, server logging and in mirout.
      . mirout: Add newer attributes only available in the new display
        config API: scaling factor, subpixel arrangement and form factor.
      . mirout: Log the orientation and logical size of each output too.
      . Replace the mir::Server-overridable Reports with Observers.
      . Add xkbcommon to mirclient.pc Requires.private.
      . Deprecate legacy toolkit APIs that will be removed in Mir 1.0
      . Introduced 'client-side vsync', which dramatically reduces latency
        from the client to the screen (particularly for nested servers like
    - Bugs fixed:
      . [performance] Restore support for better-than-triple buffering by
        default. (LP: #1240909)
      . Frame rate is artificially low on Diamondville Intel Atom systems due
        to aggressive power management (LP: #1388490)
      . [testsfail] failure in CI in
        (LP: #1394369)
      . [trusted prompt sessions] Can't open two prompt sessions at the same
        time (LP: #1494197)
      . Changing scale, formFactor or DPI in display configuration causes
        renderer teardown/recreate unnecessarily (LP: #1556142)
      . [testsfail] ApplicationNotRespondingDetection.failure_to_pong_is_
        noticed (LP: #1570327)
      . CI failure in TestClientInput.receives_one_touch_event_per_frame
        (LP: #1570698)
      . Mir-on-X mouse input is jerky/stuttery compared to Mir-on-KMS
        (LP: #1576600)
      . [regression] Two fingers in mir_proving_server now resizes/moves app
        windows (two finger apps unusable) (LP: #1586311)
      . Pointer/cursor input lag in unity8 session (LP: #1591328)
      . PointerConfinement.test_we_update_our_confined_region_on_a_resize


Changed in mir (Ubuntu):
status: New → Fix Released
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers