Mir

'make abi-check' fails to detect symbol version changes that break the ABI

Bug #1626888 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
New
Undecided
Unassigned
mir (Ubuntu)
New
Undecided
Unassigned

Bug Description

'make abi-check' fails to detect symbol version changes that break the ABI.

Like most people I assumed bug 1617865 occurred due to a simple mistake like us releasing Mir 0.24.0 without checking for ABI breaks.

Well, now I've compared 0.23, 0.24 and trunk, and even tried making similar breaks. And in all cases 'make abi-check' has failed to detect the break (symbols keep the same name but change version stanzas).

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Oh, we might be skipping too much due to:

------------------------------------------------------------
revno: 3373 [merge]
author: Alberto Aguirre <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Tue 2016-03-08 11:54:15 +0000
message:
  abi-check: Ignore some mircommon symbols that LTO removes.

  Approved by Alan Griffiths, mir-ci-bot.
------------------------------------------------------------

Revision history for this message
Michał Sawicz (saviq) wrote :

Syncing task from Mir.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.