Mir

[regression] Accidental libmircommon.so.6 ABI break in Mir 0.24.0: mir::dispatch::ReadableFd* moved version stanzas

Bug #1617865 reported by Daniel van Vugt on 2016-08-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Daniel van Vugt
0.24
Fix Released
Medium
Daniel van Vugt
mir (Ubuntu)
Medium
Unassigned

Bug Description

Accidental libmircommon.so.6 ABI break in Mir 0.24: mir::dispatch::ReadableFd* moved version stanzas

So for example server-mesa-x11.so.9 can no longer load because it expects from libmircommon.so.6:
   ZN3mir8dispatch10ReadableFdC1ENS_2FdERKSt8functionIFvvEE@MIR_COMMON_5.1
but actually in Mir 0.24.0 that got duplicated and changed to:
   ZN3mir8dispatch10ReadableFdC1ENS_2FdERKSt8functionIFvvEE@MIR_COMMON_0.24

https://bugs.launchpad.net/mir/+bug/1611804/comments/8

Related branches

Changed in mir:
milestone: none → 0.25.0
Changed in mir:
assignee: nobody → Daniel van Vugt (vanvugt)
status: Triaged → In Progress
Changed in mir:
importance: High → Medium
Daniel van Vugt (vanvugt) wrote :

The problem originated in:

------------------------------------------------------------
revno: 3603 [merge]
author: Kevin DuBois <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Thu 2016-07-21 06:15:04 +0000
message:
  update symbols to reflect the symbols actually captured in the 0.24 release.

  Approved by Daniel van Vugt, mir-ci-bot.
------------------------------------------------------------

tags: added: regression
summary: - Accidental libmircommon.so.6 ABI break in Mir 0.24:
+ [regression] Accidental libmircommon.so.6 ABI break in Mir 0.24:
mir::dispatch::ReadableFd* moved version stanzas
Changed in mir:
assignee: Daniel van Vugt (vanvugt) → Alan Griffiths (alan-griffiths)

I'm giving up trying to fix this as I can't make anything nice work.

Changed in mir:
assignee: Alan Griffiths (alan-griffiths) → nobody
Daniel van Vugt (vanvugt) wrote :

Given an assembler this would be simple to solve (if the offending code was also maintained in assembly). We're only fighting with the high level tools right now to make them do what we want.

I know it should be possible to fix this properly, in theory. But it's unclear if the standard tools will let us.

Changed in mir:
assignee: nobody → Mir development team (mir-team)
Alan Griffiths (alan-griffiths) wrote :

libstdc++ has similar needs. One of the maintainers suggested looking in compatibility.cc - but didn't understand the magic, and I've tried what looks to be useful (and, at least, got visible aliases in the .o).

Changed in mir:
assignee: Mir development team (mir-team) → Daniel van Vugt (vanvugt)
Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.25.0

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt) wrote :

Fix committed to lp:mir/0.24 at revision 3633, scheduled for release in Mir 0.24.1

summary: - [regression] Accidental libmircommon.so.6 ABI break in Mir 0.24:
+ [regression] Accidental libmircommon.so.6 ABI break in Mir 0.24.0:
mir::dispatch::ReadableFd* moved version stanzas
Changed in mir (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.25.0

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.24.1+16.10.20160928-0ubuntu1

---------------
mir (0.24.1+16.10.20160928-0ubuntu1) yakkety; urgency=medium

  * New upstream release 0.24.1 (https://launchpad.net/mir/+milestone/0.24.1)
    - ABI summary:
      . All ABI numbers remain unchanged.
      . mircommon ABI at 6, but now including a symbol misplaced in 0.24.0
    - Bugs fixed:
      . mirserver ignored further keymap configuration changes after a keyboard
        is configured (LP: #1626435)
      . fix for libmircommon.so.6 ABI break: version stanza of
        mir::dispatch::ReadableFd* moved to newer version (LP: #1617865)
      . clang builds fail (again) (LP: #1609612)
      . Valgrind errors in NesterServer.* cause subsequent tests
        (ServerDisconnect, ServerStartup, UnresponsiveClient) to fail
        (LP: #1612012)
      . Break potentially infinite loop in search for next session to focus
        (LP: #1625401)

 -- Andreas Pokorny <email address hidden> Wed, 28 Sep 2016 12:09:49 +0000

Changed in mir (Ubuntu):
status: Triaged → Fix Released
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers