mirtest-dev: mock_display_configuration.h uses "mg" without defining it
Bug #1614983 reported by
Gerry Boland
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Daniel van Vugt | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
I was trying to use mirtest doubles/
As workaround, I import it like this:
namespace mg = mir::graphics; // BUG: needed for mock_display_
#include <mir/test/
Related branches
lp:~vanvugt/mir/fix-1614983
- Kevin DuBois (community): Approve
- Mir CI Bot: Needs Fixing (continuous-integration)
- Chris Halse Rogers: Approve
- Alan Griffiths: Approve
-
Diff: 183 lines (+23/-31)8 files modifiedinclude/server/mir/compositor/scene.h (+1/-1)
include/server/mir/scene/surface.h (+1/-1)
include/test/mir/test/doubles/mock_display_configuration.h (+4/-4)
include/test/mir_test_framework/fake_input_device.h (+4/-5)
include/test/mir_test_framework/stub_server_platform_factory.h (+2/-10)
tests/acceptance-tests/test_nested_input.cpp (+1/-1)
tests/mir_test_framework/fake_input_device_impl.cpp (+1/-0)
tests/mir_test_framework/fake_input_device_impl.h (+9/-9)
Changed in mir: | |
assignee: | nobody → Daniel van Vugt (vanvugt) |
milestone: | none → 0.25.0 |
status: | Triaged → In Progress |
Changed in mir: | |
status: | In Progress → Fix Committed |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Yeah headers shouldn't use aliases like that at all. Especially public headers.