Valgrind errors in NesterServer.* cause subsequent tests (ServerDisconnect, ServerStartup, UnresponsiveClient) to fail
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Mir |
Confirmed
|
Medium
|
Alexandros Frantzis | |
| 0.24 |
Fix Released
|
Medium
|
Alexandros Frantzis | |
| mir (Ubuntu) |
Medium
|
Unassigned |
Bug Description
Tests always fail together: ServerDisconnect, ServerStartup, UnresponsiveClient
17:27:52 9: [ FAILED ] 5 tests, listed below:
17:27:52 9: [ FAILED ] ServerDisconnec
17:27:52 9: [ FAILED ] ServerDisconnec
17:27:52 9: [ FAILED ] ServerStartup.
17:27:52 9: [ FAILED ] ServerStartup.
17:27:52 9: [ FAILED ] UnresponsiveCli
This is happening regularly in CI. These failures occur together.
Related branches
- Cemil Azizoglu (community): Approve on 2016-08-18
- Mir CI Bot: Approve (continuous-integration) on 2016-08-18
- Alan Griffiths: Approve on 2016-08-18
- Kevin DuBois (community): Approve on 2016-08-18
-
Diff: 133 lines (+107/-0)3 files modifiedsrc/server/graphics/nested/display_buffer.cpp (+1/-0)
tests/unit-tests/platforms/nested/CMakeLists.txt (+1/-0)
tests/unit-tests/platforms/nested/test_nested_display_buffer.cpp (+105/-0)
Alexandros Frantzis (afrantzis) wrote : | #2 |
The failures are caused by valgrind errors found in previous tests. The tests fail together because the all fork processes which, when exiting, fail due to the pending valgrind errors.
summary: |
- Tests always fail together: ServerDisconnect, ServerStartup, - UnresponsiveClient + Valgrind errors in NesterServer.* cause subsequent test + (ServerDisconnect, ServerStartup, UnresponsiveClient) to fail |
summary: |
- Valgrind errors in NesterServer.* cause subsequent test + Valgrind errors in NesterServer.* cause subsequent tests (ServerDisconnect, ServerStartup, UnresponsiveClient) to fail |
Changed in mir: | |
assignee: | nobody → Alexandros Frantzis (afrantzis) |
Changed in mir: | |
milestone: | none → 0.25.0 |
Mir CI Bot (mir-ci-bot) wrote : | #3 |
Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.25.0
Changed in mir: | |
status: | New → Fix Committed |
Daniel van Vugt (vanvugt) wrote : | #4 |
Still happening (from a new root cause?)
Daniel van Vugt (vanvugt) wrote : | #5 |
Still happening in the 0.24 branch:
Changed in mir (Ubuntu): | |
importance: | Undecided → Medium |
status: | New → Triaged |
Daniel van Vugt (vanvugt) wrote : | #6 |
Fix committed to lp:mir/0.24 at revision 3640, scheduled for release in Mir 0.24.1
Launchpad Janitor (janitor) wrote : | #7 |
This bug was fixed in the package mir - 0.24.1+
---------------
mir (0.24.1+
* New upstream release 0.24.1 (https:/
- ABI summary:
. All ABI numbers remain unchanged.
. mircommon ABI at 6, but now including a symbol misplaced in 0.24.0
- Bugs fixed:
. mirserver ignored further keymap configuration changes after a keyboard
is configured (LP: #1626435)
. fix for libmircommon.so.6 ABI break: version stanza of
. clang builds fail (again) (LP: #1609612)
. Valgrind errors in NesterServer.* cause subsequent tests
(LP: #1612012)
. Break potentially infinite loop in search for next session to focus
(LP: #1625401)
-- Andreas Pokorny <email address hidden> Wed, 28 Sep 2016 12:09:49 +0000
Changed in mir (Ubuntu): | |
status: | Triaged → Fix Released |
Daniel van Vugt (vanvugt) wrote : | #9 |
Indeed the cause is again valgrind errors in NestedServer tests. But should we be reusing the same bug? Just search for "==12777==":
20:13:30 9: [----------] 25 tests from NestedServer
20:13:30 9: [ RUN ] NestedServer.
20:13:31 9: [2016-11-02 20:13:31.685261] mirserver: Starting
20:13:31 9: [2016-11-02 20:13:31.689667] mirserver: Selected driver: mir:stub-graphics (version 0.25.0)
20:13:31 9: [2016-11-02 20:13:31.733003] mirserver: Using software cursor
20:13:32 9: [2016-11-02 20:13:32.118804] mirserver: Selected input driver: mir:stub-input (version: 0.25.0)
20:13:32 9: [2016-11-02 20:13:32.128108] mirserver: Mir version 0.25.0
20:13:32 9: [2016-11-02 20:13:32.211391] mirserver: Starting
20:13:34 9: [2016-11-02 20:13:34.070068] mirserver: Using nested cursor
20:13:34 9: ==12777== Thread 9:
20:13:34 9: ==12777== Invalid read of size 4
20:13:34 9: ==12777== at 0x540688F: MirWaitHandle:
20:13:34 9: ==12777== by 0x5406401: void std::condition_
20:13:34 9: ==12777== by 0x5406376: MirWaitHandle:
20:13:34 9: ==12777== by 0x54774D9: mir_connection_
20:13:34 9: ==12777== by 0x517576D: (anonymous namespace)
20:13:34 9: ==12777== by 0x5175D95: mir::graphics:
....
Changed in mir: | |
milestone: | 0.25.0 → 0.26.0 |
Changed in mir: | |
milestone: | 0.26.0 → none |
Changed in mir: | |
importance: | High → Medium |
Michał Sawicz (saviq) wrote : | #10 |
Syncing task from Mir.
This is happening too often. Bumping importance.