Mir

mir_acceptance_tests.bin: double free or corruption (fasttop)

Bug #1603114 reported by Kevin DuBois on 2016-07-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Kevin DuBois
mir (Ubuntu)
Undecided
Unassigned

Bug Description

Seen a few times, typical thing seen is a memory issue in the acceptance tests:
https://launchpadlibrarian.net/272973212/buildlog_ubuntu-yakkety-
i386.mir_0.24.0+16.10.20160714-0ubuntu1_BUILDING.txt.gz

8: CMakeFiles CTestTestfile.cmake Makefile cmake_install.cmake mir_acceptance_tests_precompiled.hpp.gch precompiled.hpp.compileflags precompiled.hpp.compileflags.processed throwback Error in `/«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin': double free or corruption (fasttop): 0x0a1b5e40 CMakeFiles CTestTestfile.cmake Makefile cmake_install.cmake mir_acceptance_tests_precompiled.hpp.gch precompiled.hpp.compileflags precompiled.hpp.compileflags.processed throwback
8: ======= Backtrace: =========
8: /lib/i386-linux-gnu/libc.so.6(+0x672d7)[0xf70872d7]
8: /lib/i386-linux-gnu/libc.so.6(+0x6d227)[0xf708d227]
8: /lib/i386-linux-gnu/libc.so.6(+0x6dae1)[0xf708dae1]
8: /usr/lib/i386-linux-gnu/libstdc++.so.6(_ZdlPv+0x18)[0xf72884b8]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(_ZNSt6vectorISt8weak_ptrIN3mir5input11InputDeviceEESaIS4_EED2Ev+0x8b)[0x86213bb]
8: /lib/i386-linux-gnu/libc.so.6(+0x2e933)[0xf704e933]
8: /lib/i386-linux-gnu/libc.so.6(+0x2e98f)[0xf704e98f]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(_ZN18mir_test_framework28InterprocessClientServerTestD1Ev+0x12a)[0x8615eda]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin[0x8352b85]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(_ZN7testing4Test11DeleteSelf_Ev+0x28)[0x8647494]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc+0x45)[0x86536f9]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc+0x50)[0x864ddff]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(_ZN7testing8TestInfo3RunEv+0x13b)[0x86318a7]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(_ZN7testing8TestCase3RunEv+0x103)[0x8631ffd]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(_ZN7testing8internal12UnitTestImpl11RunAllTestsEv+0x2e7)[0x8639a51]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc+0x45)[0x8654bd7]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc+0x50)[0x864ed4f]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(_ZN7testing8UnitTest3RunEv+0xc6)[0x86383c2]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(_ZN18mir_test_framework4mainEiPPc+0x3c)[0x82822dc]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin(main+0x6d)[0x828250d]
8: /lib/i386-linux-gnu/libc.so.6(__libc_start_main+0xf7)[0xf70385f7]
8: /«BUILDDIR»/mir-0.24.0+16.10.20160714/obj-i686-linux-gnu/bin/mir_acceptance_tests.bin[0x828267e]
8: ======= Memory map: ========

Related branches

summary: - ftbfs i386 0.24 series (tests fail with memory problems)
+ mir_acceptance_tests.bin': double free or corruption (fasttop)
description: updated
summary: - mir_acceptance_tests.bin': double free or corruption (fasttop)
+ mir_acceptance_tests.bin: double free or corruption (fasttop)
Changed in mir:
milestone: 0.24.0 → 0.25.0
Kevin DuBois (kdub) on 2016-07-15
Changed in mir:
assignee: nobody → Kevin DuBois (kdub)
status: New → In Progress
tags: added: release-blocker
Kevin DuBois (kdub) wrote :

seems that these tests cause the corruption first (ie, running --gtest_filter="-NestedInput" succeeds)

NestedInput.nested_input_device_hub_lists_keyboard
NestedInput.on_add_device_observer_gets_device_added_calls_on_existing_devices
NestedInput.device_added_on_host_triggeres_nested_device_observer
NestedInput.on_input_device_state_nested_server_emits_input_device_state

Kevin DuBois (kdub) wrote :

so, what's happening is that the mir-test-assist library uses StubInputPlatform, and then probes the stub-input.so platform. On the affected platforms (i386, arm64, ppc64el), the linker will run the init hooks on the static variables once, and free twice (maybe not smart enough to figure out static linked vs dlopened on these platforms?). At any rate, seems like we're violating ODR with the current linking. Will rework things so that the tests that need stub_input_platform sources will link them in as objects.

Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.25.0

Changed in mir:
status: In Progress → Fix Committed
Kevin DuBois (kdub) on 2016-07-20
Changed in mir:
milestone: 0.25.0 → 0.24.0
no longer affects: mir/0.24
Launchpad Janitor (janitor) wrote :
Download full text (5.7 KiB)

This bug was fixed in the package mir - 0.24.0+16.10.20160815.3-0ubuntu1

---------------
mir (0.24.0+16.10.20160815.3-0ubuntu1) yakkety; urgency=medium

  * New upstream release 0.24.0 (https://launchpad.net/mir/+milestone/0.24.0)
    - ABI summary:
      . mirclient ABI unchanged at 9
      . mirserver ABI bumped to 41
      . mircommon ABI unchanged at 6
      . mirplatform ABI bumped to 12
      . mirprotobuf ABI unchanged at 3
      . mirplatformgraphics ABI bumped to 10
      . mirclientplatform ABI unchanged at 5
      . mirinputplatform ABI unchanged at 5
    - Enhancements:
      . Added a new tool 'mirvanity' which can use a high speed video camera
        to measure client-to-screen latency.
      . Added (build-time) support for desktop full OpenGL servers (disabled
        by default in favor of GLESv2).
      . Introduced new buffer semantics (NBS) and enabled it by default.
      . Avoided using libmirserver in mir_demo_standalone_render_overlays,
        making bringup traces less cluttered.
      . Removed TilingWindowManager from example servers.
      . Added two new mir_*_performance_test tools that are run as part of
        'mir_performance_tests'.
      . Added pointer confinement to the client API.
      . Added new platform supporting software EGLStreams.
      . Added an input platform that the nested server can use.
      . Allow configuration of the application_not_responding_detector
      . Handle server-side keymapping using XKBMapper.
      . Remove the offscreen display.
      . Add callback option to notify shells that the server is about to stop.
      . Add logging for ANativeWindow events on Android.
    - Bugs fixed:
      . usage of std:call_once in mirclient causes TLS collisions with some
        android devices (LP: #1599867)
      . AltGr not working on external keyboards (LP: #1565236)
      . [regression] unity8 fails to start when built with 0.24 series (lp:mir)
        (LP: #1597717)
      . CI failure in MirSurfaceVisibilityEvent.exposed_received_when_surface_
        raised_over_occluding_surface [called twice - over-saturated and active]
        (LP: #1556045)
      . package-built mir_demo_server does not start on device (LP: #1577357)
      . During surface creation, first stream in spec becomes default stream.
        (LP: #1577967)
      . mouse is getting stuck on a phantom edge (LP: #1580774)
      . [testsfail] in MirSurfaceVisibilityEvent.exposed_received_when_surface_
        raised_over_occluding_surface [never called] (LP: #1581385)
      . [enhancement] Add support for full OpenGL compositing (LP: #1420581)
      . [testsfail] ServerSignal.terminate_handler_is_called_for_SIGINT|SIGTERM
        (LP: #1570353)
      . [testsfail] ClientLatency.triple_buffered_client_has_less_than_two_
        frames_latency (LP: #1576690)
      . [testsfail] NestedServer.when_monitor_plugged_in_client_is_notified_of_
        new_display_configuration (LP: #1576760)
      . mir server crashed in what(): drmModeMoveCursor failed (returned -13)
        (LP: #1579630)
      . mirtest-dev is hard to use as the objects used are compiled with LTO
        (LP: #1583536)
      . [testsfail] ClientLogging.repo...

Read more...

Changed in mir (Ubuntu):
status: New → Fix Released
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers