Mir

During surface creation, first stream in spec becomes default stream.

Bug #1577967 reported by Cemil Azizoglu on 2016-05-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
High
Unassigned
Mir
Fix Released
High
Kevin DuBois
mir (Ubuntu)
Undecided
Unassigned

Bug Description

A surface creation spec can have multiple streams. The code currently, by happenstance, makes the first stream the "default stream", i.e. instantiates a MirSurface using that stream. The MirSurface object's methods then use that stream for various purposes, e.g. to set the swap interval, to set size during resize, to query parameters of the surface, etc. Here's a list of MirSurface methods that use the default stream :

MirSurface::get_parameters(),
MirSurface::configure(),
MirSurface::attrib(),
MirSurface::handle_event()

We need to define the precise semantics of MirSurface properly in regards to the streams that may be associated with it.

Related branches

summary: - mir_surface_is_valid(surface) returns false when a presentation chain is
- used
+ During surface creation, first stream in spec becomes default stream.
description: updated
description: updated
description: updated
Changed in mir:
importance: Undecided → High
milestone: none → 0.24.0
description: updated
Cemil Azizoglu (cemil-azizoglu) wrote :

As a result of the way the code currently works, we have e.g. the following problem :

When mir_demo_client_prerendered_frames, which uses a presentation chain, is run, it works fine.

When

mir_surface_is_valid(surface)

is added after surface creation (i.e. http://bazaar.launchpad.net/~mir-team/mir/development-branch/view/head:/playground/mir_demo_client_prerendered_frames.c#L164), it fails due to the following error being set :

 "Can not create buffer stream: Error processing buffer stream create response, no ID (disconnected?)"

Kevin DuBois (kdub) wrote :

It is reasonable to have the "first" stream in multibufferstream scenarios be the stream that is affected by these client API calls. We'd have to break client API to root this concept out, which I don't think we have to do right now... seems to me this bug would be resolved by adding some tests to check that mir_surface_is_valid() works properly.

Kevin DuBois (kdub) wrote :

This bug is really about ambiguity in the clientapi, tagged to that.

tags: added: clientapi
Kevin DuBois (kdub) on 2016-05-10
Changed in mir:
status: New → Confirmed
status: Confirmed → In Progress
assignee: nobody → Kevin DuBois (kdub)
Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.24.0

Changed in mir:
status: In Progress → Fix Committed
Changed in canonical-devices-system-image:
status: New → Fix Committed
importance: Undecided → High
milestone: none → 13
Launchpad Janitor (janitor) wrote :
Download full text (5.7 KiB)

This bug was fixed in the package mir - 0.24.0+16.10.20160815.3-0ubuntu1

---------------
mir (0.24.0+16.10.20160815.3-0ubuntu1) yakkety; urgency=medium

  * New upstream release 0.24.0 (https://launchpad.net/mir/+milestone/0.24.0)
    - ABI summary:
      . mirclient ABI unchanged at 9
      . mirserver ABI bumped to 41
      . mircommon ABI unchanged at 6
      . mirplatform ABI bumped to 12
      . mirprotobuf ABI unchanged at 3
      . mirplatformgraphics ABI bumped to 10
      . mirclientplatform ABI unchanged at 5
      . mirinputplatform ABI unchanged at 5
    - Enhancements:
      . Added a new tool 'mirvanity' which can use a high speed video camera
        to measure client-to-screen latency.
      . Added (build-time) support for desktop full OpenGL servers (disabled
        by default in favor of GLESv2).
      . Introduced new buffer semantics (NBS) and enabled it by default.
      . Avoided using libmirserver in mir_demo_standalone_render_overlays,
        making bringup traces less cluttered.
      . Removed TilingWindowManager from example servers.
      . Added two new mir_*_performance_test tools that are run as part of
        'mir_performance_tests'.
      . Added pointer confinement to the client API.
      . Added new platform supporting software EGLStreams.
      . Added an input platform that the nested server can use.
      . Allow configuration of the application_not_responding_detector
      . Handle server-side keymapping using XKBMapper.
      . Remove the offscreen display.
      . Add callback option to notify shells that the server is about to stop.
      . Add logging for ANativeWindow events on Android.
    - Bugs fixed:
      . usage of std:call_once in mirclient causes TLS collisions with some
        android devices (LP: #1599867)
      . AltGr not working on external keyboards (LP: #1565236)
      . [regression] unity8 fails to start when built with 0.24 series (lp:mir)
        (LP: #1597717)
      . CI failure in MirSurfaceVisibilityEvent.exposed_received_when_surface_
        raised_over_occluding_surface [called twice - over-saturated and active]
        (LP: #1556045)
      . package-built mir_demo_server does not start on device (LP: #1577357)
      . During surface creation, first stream in spec becomes default stream.
        (LP: #1577967)
      . mouse is getting stuck on a phantom edge (LP: #1580774)
      . [testsfail] in MirSurfaceVisibilityEvent.exposed_received_when_surface_
        raised_over_occluding_surface [never called] (LP: #1581385)
      . [enhancement] Add support for full OpenGL compositing (LP: #1420581)
      . [testsfail] ServerSignal.terminate_handler_is_called_for_SIGINT|SIGTERM
        (LP: #1570353)
      . [testsfail] ClientLatency.triple_buffered_client_has_less_than_two_
        frames_latency (LP: #1576690)
      . [testsfail] NestedServer.when_monitor_plugged_in_client_is_notified_of_
        new_display_configuration (LP: #1576760)
      . mir server crashed in what(): drmModeMoveCursor failed (returned -13)
        (LP: #1579630)
      . mirtest-dev is hard to use as the objects used are compiled with LTO
        (LP: #1583536)
      . [testsfail] ClientLogging.repo...

Read more...

Changed in mir (Ubuntu):
status: New → Fix Released
Changed in mir:
status: Fix Committed → Fix Released
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers