Racy shutdown in mir_demo_client_scroll causes SEGFAULT
Bug #1560943 reported by
Alan Griffiths
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Low
|
Alan Griffiths | ||
| mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
This example responds to SIGTERM (and SIGINT) by calling exit() - without taking any precaution to prevent other threads running simultaneously. This can lead to a SEGFAULT.
I got a core by running:
$ while bin/mir_demo_server --test-timeout 1 --test-client bin/mir_
Which eventually failed this way.
Related branches
lp:~alan-griffiths/mir/workaround-1560943
- Alberto Aguirre (community): Approve
- Mir CI Bot: Needs Fixing (continuous-integration)
- Daniel van Vugt: Approve
- Kevin DuBois (community): Approve
-
Diff: 12 lines (+1/-1)1 file modifiedexamples/scroll.cpp (+1/-1)
lp:mir
- PS Jenkins bot (community): Approve (continuous-integration)
- Alan Griffiths: Approve
- Kevin DuBois (community): Approve
-
Diff: 1373 lines (+579/-161)23 files modified3rd_party/android-input/android/frameworks/base/services/input/MirLog.cpp (+157/-5)
include/test/mir_test_framework/display_server_test_fixture.h (+2/-0)
include/test/mir_test_framework/stub_client_connection_configuration.h (+35/-0)
include/test/mir_test_framework/testing_client_configuration.h (+43/-0)
include/test/mir_test_framework/testing_process_manager.h (+7/-8)
src/client/mir_client_library.cpp (+39/-17)
src/server/graphics/android/hwc_common_device.cpp (+15/-13)
src/server/options/program_option.cpp (+2/-1)
tests/acceptance-tests/test_client_authorization.cpp (+7/-0)
tests/acceptance-tests/test_client_focus_notification.cpp (+2/-9)
tests/acceptance-tests/test_client_input.cpp (+8/-15)
tests/acceptance-tests/test_client_library.cpp (+30/-17)
tests/acceptance-tests/test_focus_selection.cpp (+2/-9)
tests/acceptance-tests/test_server_shutdown.cpp (+2/-9)
tests/acceptance-tests/test_shell_control_of_surface_configuration.cpp (+2/-9)
tests/acceptance-tests/test_surfaceloop.cpp (+3/-10)
tests/acceptance-tests/test_surfaces_with_output_id.cpp (+2/-9)
tests/mir_test_framework/CMakeLists.txt (+1/-0)
tests/mir_test_framework/display_server_test_fixture.cpp (+9/-6)
tests/mir_test_framework/testing_client_options.cpp (+126/-0)
tests/mir_test_framework/testing_process_manager.cpp (+41/-1)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+25/-1)
tests/unit-tests/logging/test_legacy_input_report.cpp (+19/-22)
lp:~albaguirre/mir/simplify-scroll-example
- Alan Griffiths: Disapprove
- Kevin DuBois (community): Approve
- Mir CI Bot: Approve (continuous-integration)
-
Diff: 224 lines (+18/-173)2 files modifiedexamples/CMakeLists.txt (+1/-7)
examples/scroll.cpp (+17/-166)
| Changed in mir: | |
| assignee: | nobody → Alan Griffiths (alan-griffiths) |
| importance: | Undecided → Low |
| status: | New → In Progress |
| Changed in mir: | |
| milestone: | none → 0.22.0 |
Revision history for this message
| Mir CI Bot (mir-ci-bot) wrote | #1 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in mir (Ubuntu): | |
| status: | New → Fix Released |
To post a comment you must log in.
Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.22.0