Focus is lost completely when the focussed window closes

[William Hua]

When a child surface is created, we get two MirSurfaceEvents with the attribute mir_surface_attrib_focus: one for unfocusing the parent, the other for focusing the child. So the child has the focus.

When the focused child is released, the parent doesn't re-acquire the focus, i.e. we only get a MirSurfaceEvent unfocusing the child. Here's a sample event log:

SURFACE
 Attribute focus
 Value 0
SURFACE
 Attribute focus
 Value 1
MOTION
 Device 12
 Action up
 Modifiers
 Button State
 Offset (164.000000, 70.000000)
 Event Time 1436820860654839000
MOTION
 Device 12
 Action motion
 Modifiers
 Button State
 Offset (164.000000, 70.000000)
 Event Time 1436820860654839000
KEY
 Device 11
 Action down
 Modifiers
 Key Code 65307
 Scan Code 1
 Event Time 1436820867212029000
SURFACE
 Attribute focus
 Value 0
SURFACE
 Attribute 5
 Value 0

[Daniel van Vugt (vanvugt)]

In the case of Xmir, clients (the X server) need to be able to specify what sibling window/surface should be focused next.

App's are quite frustrating to use with the keyboard while we can't implement XSetInputFocus() and focus regularly gets lost completely.

[Daniel van Vugt (vanvugt)]

So two things are required here:

1. More sane demo server behaviour, such that we're never left with zero focussed surfaces.

2. A client API for setting/hinting/requesting what to focus (required by Xmir to navigate between multiple windows like when closing an Open File dialog and returning to the app). Or even when closing a tooltip; please return me to the app!

[Mir CI Bot (mir-ci-bot)]

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.24.0

[Daniel van Vugt (vanvugt)]

I'm a bit concerned if Mir isn't getting a fix for this. How long before the fix in MirAL is the fix in Mir?