mir_acceptance_tests crashes: NestedServer.client_may_connect_to_nested_server_and_create_surface

[Daniel van Vugt]

Acceptance test crashes: NestedServer.client_may_connect_to_nested_server_and_create_surface

[ RUN ] NestedServer.client_may_connect_to_nested_server_and_create_surface
terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<std::logic_error> >'
  what(): stop_server() failed to stop server
Aborted (core dumped)

Test case:
  mir_acceptance_tests --gtest_filter="NestedServer.*" --gtest_repeat=1000

It seems we've tried (and apparently failed) to fix this in the past (bug 1430000). But it's still happening today in Mir 0.14 r2672.

[Alexandros Frantzis (afrantzis)]

I am not able to reproduce this with lp:mir r2722.

[Daniel van Vugt (vanvugt)]

Confirmed r2722 does not have the bug.

With more effort, I have now bisected the issue and found it was fixed by r2690:

------------------------------------------------------------
revno: 2690 [merge]
author: Alberto Aguirre <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Sat 2015-06-20 00:13:06 +0000
message:
  Fix potential data races and mutex locking order issues.

  Avoid FD data race in AsyncServerRunner
  Avoid data race on display_server pointer in ServerRunner
  Avoid potential lock ordering issues in mir::client::ConnectionSurfaceMap.

  Approved by PS Jenkins bot, Alan Griffiths.
------------------------------------------------------------