[regression] Lost API for creating freestyle surfaces
Bug #1457987 reported by
William Hua
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Alan Griffiths | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
mir_surface_
Related branches
lp:~alan-griffiths/mir/fix-1457987
- PS Jenkins bot (community): Approve (continuous-integration)
- Alberto Aguirre (community): Approve
- Chris Halse Rogers: Approve
-
Diff: 334 lines (+213/-3)6 files modifiedexamples/server_example_canonical_window_manager.cpp (+17/-0)
include/client/mir_toolkit/mir_surface.h (+45/-0)
src/client/mir_surface_api.cpp (+33/-2)
src/client/symbols.map (+3/-0)
src/server/shell/canonical_window_manager.cpp (+17/-0)
tests/acceptance-tests/test_surface_placement.cpp (+98/-1)
Changed in mir: | |
status: | New → In Progress |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
Changed in mir: | |
importance: | Undecided → Medium |
summary: |
- Missing API for creating freestyle surfaces + [regression] No API for creating freestyle surfaces |
tags: | added: regression |
Changed in mir: | |
milestone: | none → 0.14.0 |
summary: |
- [regression] No API for creating freestyle surfaces + [regression] Lost API for creating freestyle surfaces |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
There ought to be mir_connection_ create_ surface_ spec_for_ XXX functions covering all the surface types.
$ grep mir_connection_ create_ spec_for_ include/ client/ mir_toolkit/ mir_surface. hMirSurfaceSpec * mir_connection_ create_ spec_for_ normal_ surface( MirConnection* connection, create_ spec_for_ menu(MirConnect ion* connection, create_ spec_for_ tooltip( MirConnection* connection, create_ spec_for_ modal_dialog( MirConnection* connection, create_ spec_for_ dialog( MirConnection* connection, create_ spec_for_ changes( MirConnection* connection); create_ spec_for_ input_method( MirConnection* connection,
mir_connection_
mir_connection_
mir_connection_
mir_connection_
mir_connection_
MirSurfaceSpec* mir_connection_
vs
mir_ surface_ type_normal, /**< AKA "regular" */ surface_ type_utility, /**< AKA "floating" */ surface_ type_dialog, surface_ type_overlay, /**< \deprecated Use "gloss" instead. */ surface_ type_gloss = mir_surface_ type_overlay, surface_ type_freestyle, surface_ type_popover, /**< \deprecated Choose "menu" or "tip" */ surface_ type_menu = mir_surface_ type_popover, surface_ type_inputmetho d, /**< AKA "OSK" or handwriting etc. */ surface_ type_satellite, /**< AKA "toolbox"/"toolbar" */ surface_ type_tip, /**< AKA "tooltip" */
mir_
mir_
mir_
mir_
mir_
mir_
mir_
mir_
mir_
mir_
So we're missing
mir_ connection_ create_ spec_for_ utility, create_ spec_for_ _gloss = mir_surface_ type_overlay, surface_ type_freestyle, surface_ type_satellite, surface_ type_tip,
mir_connection_
mir_
mir_
mir_