Acceptance tests link with static versions of client library and server components

[Alexandros Frantzis]

Acceptance tests link with static versions of client library and server components [1]. This is bad because:

1. mir_acceptance_tests ends up with multiples versions of static symbols, which can lead to strange errors
2. We can inadvertently use private symbols, so the acceptance tests won't fail if we forget to make a symbol public

The tests failures seen in https://code.launchpad.net/~afrantzis/mir/client-surface-buffering-mode/+merge/256455, are
a result of (1). What happens is that we register valid surfaces with the built-in (picked up from mirclient-static) version of the MirSurface::is_valid() symbol (and therefore the corresponding valid_surfaces static container), but subsequently end up using the libmirclient.so.8 version of MirSurface::is_valid() symbol (and therefore the corresponding different and empty valid_surfaces static container).

The aforementioned MP also suffers from (2), since although I forgot to expose the new client library symbol, the tests work fine. Depending on the particular case, we may only find out about the problem after the release, when a user tries to use the symbol and fail.

[1] libmirclient-static.a, lib3rd_party.a, libmirclientrpc.a, libmirclientlttngstatic.a, libxcursorloader.a

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.13.0

[Launchpad Janitor (janitor)]

This bug was fixed in the package mir - 0.13.1+15.10.20150520-0ubuntu1

---------------
mir (0.13.1+15.10.20150520-0ubuntu1) wily; urgency=medium

  [ Cemil Azizoglu ]
  * New upstream release 0.13.1 (https://launchpad.net/mir/+milestone/0.13.1)
    - ABI summary: No ABI break. Servers and clients do not need rebuilding.
      . Mirclient ABI unchanged at 8
      . Mircommon ABI unchanged at 4
      . Mirplatform ABI unchanged at 7
      . Mirserver ABI unchanged at 31
    - Bug fixes:
      . Can't load app purchase UI without a U1 account (LP: #1450377)
      . Crash because uncaught exception in mir::events::add_touch (LP: #1437357)

 -- CI Train Bot <email address hidden> Wed, 20 May 2015 21:20:15 +0000