Exceptions thrown due to EGL failures don't include EGL error codes
Bug #1444938 reported by
Alexandros Frantzis
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Alexandros Frantzis | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Exceptions thrown due to EGL failures don't include EGL error codes, making it hard to uncover the cause of the failure, especially in reports coming from users and production systems.
Related branches
lp:~afrantzis/mir/report-egl-errors-in-exceptions
- PS Jenkins bot (community): Approve (continuous-integration)
- Kevin DuBois (community): Approve
- Alan Griffiths: Approve
- Robert Carr (community): Approve
-
Diff: 625 lines (+267/-32)15 files modifiedsrc/include/platform/mir/graphics/egl_error.h (+40/-0)
src/platform/graphics/CMakeLists.txt (+1/-0)
src/platform/graphics/egl_error.cpp (+72/-0)
src/platform/graphics/egl_resources.cpp (+3/-2)
src/platform/symbols.map (+1/-0)
src/platforms/android/server/buffer.cpp (+3/-2)
src/platforms/android/server/gl_context.cpp (+6/-10)
src/platforms/mesa/server/buffer_allocator.cpp (+2/-1)
src/platforms/mesa/server/display_helpers.cpp (+9/-7)
src/server/graphics/nested/display.cpp (+6/-5)
src/server/graphics/nested/display_buffer.cpp (+2/-1)
src/server/graphics/offscreen/display.cpp (+3/-2)
src/server/graphics/surfaceless_egl_context.cpp (+3/-2)
tests/unit-tests/graphics/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/test_egl_error.cpp (+115/-0)
Changed in mir: | |
milestone: | none → 0.13.0 |
summary: |
- Exceptions thrown due to EGL and GL failure don't include EGL/GL error - codes + Exceptions thrown due to EGL failures don't include EGL error codes |
description: | updated |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Also be wary of bug 1381398. I guess we can still resolve both independently.