[regression] Deadlock in TimeoutFrameDroppingPolicy logic results in frozen unity8
Bug #1421255 reported by
kevin gunn
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Critical
|
Alberto Aguirre | ||
mir (Ubuntu) |
Fix Released
|
Critical
|
Unassigned |
Bug Description
spawning from bug 1417773 "Unity8 completely frozen (unable to unlock, receive calls, etc)"
See Saviq's comment #4 & 5, duflu's comment #7 in bug 1417773
Related branches
lp:~albaguirre/mir/fix-1421255
- Kevin DuBois (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Alan Griffiths: Approve
-
Diff: 1283 lines (+368/-132)23 files modifiedinclude/server/mir/time/timer.h (+28/-4)
src/include/server/mir/compositor/frame_dropping_policy_factory.h (+22/-5)
src/include/server/mir/glib_main_loop.h (+11/-6)
src/include/server/mir/glib_main_loop_sources.h (+3/-1)
src/server/compositor/buffer_queue.cpp (+28/-13)
src/server/compositor/buffer_queue.h (+12/-4)
src/server/compositor/timeout_frame_dropping_policy_factory.cpp (+17/-9)
src/server/compositor/timeout_frame_dropping_policy_factory.h (+6/-2)
src/server/glib_main_loop.cpp (+23/-6)
src/server/glib_main_loop_sources.cpp (+15/-3)
tests/include/mir_test_doubles/mock_frame_dropping_policy_factory.h (+23/-4)
tests/include/mir_test_doubles/mock_main_loop.h (+14/-6)
tests/include/mir_test_doubles/mock_timer.h (+7/-5)
tests/include/mir_test_doubles/stub_frame_dropping_policy_factory.h (+7/-3)
tests/include/mir_test_doubles/stub_timer.h (+3/-3)
tests/include/mir_test_doubles/triggered_main_loop.h (+1/-1)
tests/mir_test_doubles/mock_frame_dropping_policy_factory.cpp (+12/-4)
tests/mir_test_doubles/mock_timer.cpp (+38/-15)
tests/mir_test_doubles/triggered_main_loop.cpp (+3/-2)
tests/unit-tests/compositor/test_buffer_queue.cpp (+10/-1)
tests/unit-tests/compositor/test_timeout_frame_dropping_policy.cpp (+36/-9)
tests/unit-tests/test_glib_main_loop.cpp (+29/-26)
tests/unit-tests/test_raii.cpp (+20/-0)
Changed in mir: | |
importance: | Undecided → Critical |
Changed in mir: | |
milestone: | none → 0.12.0 |
summary: |
- mir deadlock results in frozen unity8 + Deadlock in TimeoutFrameDroppingPolicy logic results in frozen unity8 |
Changed in mir: | |
assignee: | nobody → Alberto Aguirre (albaguirre) |
Changed in mir: | |
status: | New → In Progress |
no longer affects: | mir/0.11 |
Changed in mir (Ubuntu): | |
importance: | Undecided → Critical |
status: | New → Triaged |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in mir: | |
status: | Fix Released → Fix Committed |
milestone: | 0.13.0 → 0.12.0 |
status: | Fix Committed → Fix Released |
no longer affects: | mir/0.12 |
To post a comment you must log in.
Is there any reason to believe that Saviq's comment #4 and Saviq's comment #5 relate to the same problem?
duflu's comment makes sense for https:/ /bugs.launchpad .net/ubuntu- rtm/+source/ unity8/ +bug/1417773/ comments/ 4 but not for https:/ /bugs.launchpad .net/ubuntu- rtm/+source/ unity8/ +bug/1417773/ comments/ 5 or the earlier comment by rsalveti.