Compositor report inconsistently reports frame time during bypass, and render time otherwise
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Daniel van Vugt | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Compositor report inconsistently reports frame time during bypass, and render time otherwise. As of Mir 0.10.0 on mesa it should be reporting render time exclusively (i.e. zero for bypass). Not the frame time.
[1420787439.536901] (II) compositor: Display 0x7fcd6c000920 averaged 59.898 FPS, 0.363 ms/frame, latency 15.728 ms, 60 frames over 1.001 sec, 0% bypassed
[1420787440.538606] (II) compositor: Display 0x7fcd6c000920 averaged 59.897 FPS, 0.404 ms/frame, latency 15.625 ms, 60 frames over 1.001 sec, 0% bypassed
[1420787442.569138] (II) compositor: Display 0x7fcd6c000920 averaged 22.161 FPS, 0.442 ms/frame, latency 15.153 ms, 45 frames over 2.030 sec, 0% bypassed
[1420787442.608043] (II) compositor: Display 0x7fcd6c000920 bypass ON
[1420787443.576615] (II) compositor: Display 0x7fcd6c000920 averaged 59.555 FPS, 16.375 ms/frame, latency 15.763 ms, 60 frames over 1.007 sec, 98% bypassed
[1420787444.578286] (II) compositor: Display 0x7fcd6c000920 averaged 59.899 FPS, 16.652 ms/frame, latency 16.100 ms, 60 frames over 1.001 sec, 100% bypassed
[1420787445.580003] (II) compositor: Display 0x7fcd6c000920 averaged 59.897 FPS, 16.653 ms/frame, latency 16.115 ms, 60 frames over 1.001 sec, 100% bypassed
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Alexandros Frantzis (community): Approve
- Alan Griffiths: Approve
- Kevin DuBois (community): Approve
-
Diff: 412 lines (+124/-37)13 files modifiedplayground/demo-shell/demo_compositor.cpp (+3/-2)
src/include/server/mir/compositor/compositor_report.h (+2/-1)
src/server/compositor/default_display_buffer_compositor.cpp (+3/-2)
src/server/report/logging/compositor_report.cpp (+14/-7)
src/server/report/logging/compositor_report.h (+3/-1)
src/server/report/lttng/compositor_report.cpp (+8/-3)
src/server/report/lttng/compositor_report.h (+2/-1)
src/server/report/lttng/compositor_report_tp.h (+11/-3)
src/server/report/null/compositor_report.cpp (+5/-1)
src/server/report/null/compositor_report.h (+2/-1)
tests/include/mir_test_doubles/mock_compositor_report.h (+4/-2)
tests/unit-tests/compositor/test_default_display_buffer_compositor.cpp (+33/-5)
tests/unit-tests/logging/test_compositor_report.cpp (+34/-8)
Changed in mir: | |
status: | Triaged → In Progress |
milestone: | none → 0.11.0 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Fix committed into lp:mir at revision 2212, scheduled for release in mir, milestone 0.11.0