Leaks in death tests can cause subsequent tests in the same process to fail

Bug #1402160 reported by Alexandros Frantzis
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Alexandros Frantzis
mir (Ubuntu)
Fix Released

Bug Description

To reproduce:

valgrind --error-exitcode=1 --trace-children=yes --leak-check=full --show-leak-kinds=definite --errors-for-leak-kinds=definite bin/mir_acceptance_tests --gtest_filter=ClientLibraryErrorsDeathTest*:ClientLibraryThread*

The ClientLibraryThread tests should pass and not report any definite leaks. It's expected to get leaks from the DeathTests.

Note that for me (and Daniel, see [1]), this is still a problem even with Christopher's fix ([2]). So, this is a real issue, just not the one that was blocking CI.

I don't know why on some setups (e.g. Alan's) this fix seems to have no effect. Perhaps it was a combination of this leak and the one fixed by Chris that complicated the situation, and now that the other leak is fixed this will work properly on all setups.

[1] https://code.launchpad.net/~raof/mir/fix-all-the-CI/+merge/244526/comments/603009
[2] https://code.launchpad.net/~raof/mir/fix-all-the-CI/+merge/244526

Related branches

summary: - Leaks in death tests can cause subsequent tests ran in the same process
- to fail
+ Leaks in death tests can cause subsequent tests in the same process to
+ fail
Changed in mir:
milestone: none → 0.10.0
assignee: nobody → Alexandros Frantzis (afrantzis)
status: New → In Progress
status: In Progress → Fix Committed
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

mir (0.10.0+15.04.20150107.2-0ubuntu1) vivid; urgency=medium

Changed in mir (Ubuntu):
importance: Undecided → Medium
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers