Mir

Some integration tests (TestClientIPCRender) still touch the graphics hardware, despite default option --tests-use-real-graphics == FALSE

Bug #1373212 reported by Daniel van Vugt
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mir
Won't Fix
Medium
Unassigned

Bug Description

Some integration tests (TestClientIPCRender) still touch the graphics hardware, despite default option --tests-use-real-graphics == FALSE.

So then, if the build machine doesn't have its graphics drivers in order, we notice tests failing when they actually shouldn't be running at all:

[ RUN ] TestClientIPCRender.test_accelerated_render
libEGL warning: DRI2: xcb_connect failed
libEGL warning: DRI2: xcb_connect failed
/tmp/buildd/mir-0.7.3+14.10.20140918.1bzr1934pkg0utopic758+autopilot0/tests/integration-tests/client/test_client_render.cpp:409: Failure
Value of: red_pattern.check(*region0)
Actual: false
Expected: true
[ FAILED ] TestClientIPCRender.test_accelerated_render (31 ms)
[ RUN ] TestClientIPCRender.test_accelerated_render_double
libEGL warning: DRI2: xcb_connect failed
libEGL warning: DRI2: xcb_connect failed
/tmp/buildd/mir-0.7.3+14.10.20140918.1bzr1934pkg0utopic758+autopilot0/tests/integration-tests/client/test_client_render.cpp:423: Failure
Value of: red_pattern.check(*region0)
Actual: false
Expected: true
/tmp/buildd/mir-0.7.3+14.10.20140918.1bzr1934pkg0utopic758+autopilot0/tests/integration-tests/client/test_client_render.cpp:427: Failure
Value of: green_pattern.check(*region1)
Actual: false
Expected: true
[ FAILED ] TestClientIPCRender.test_accelerated_render_double (32 ms)

See also: bug 1221373

Tags: testsfail

Related branches

Changed in mir:
assignee: nobody → Daniel van Vugt (vanvugt)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

I am OK with making the tests respect the --tests-use-real-graphics flag, but I would argue that we should then make the Android acceptance and integration tests run with --tests-use-real-graphics=true (since they do run on a capable device), so that we keep exercising the Mir/driver boundary.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Hence "See also: bug 1221373". Although I argue it should not be on the critical-CI-path. It will solve _many_ issues if we fix this and stop touching the driver/hardware in CI.

Changed in mir:
assignee: Daniel van Vugt (vanvugt) → nobody
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision 2937, scheduled for release in mir, milestone 0.17.0

Changed in mir:
status: Triaged → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Won't Fix: Per the attached branch this option has been removed.

Changed in mir:
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.