Touch screen coordinates don't rotate with the screen
Bug #1349660 reported by
Daniel van Vugt
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
High
|
Andreas Pokorny | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Touch screen coordinates don't rotate with the screen.
Test case:
1. Find a laptop with a touch screen.
2. Start mir_demo_
3. Rotate the screen: Ctrl+Alt+Arrows
Expected: Touch to also be rotated.
Observed: Touch coordinates stay in the original native orientation - don't match up with fingers any more.
Related branches
lp:~andreas-pokorny/mir/map-touchscreen-to-output
- Daniel van Vugt: Abstain
- Mir CI Bot: Approve (continuous-integration)
- Alan Griffiths: Approve
-
Diff: 1859 lines (+946/-126)29 files modifiedinclude/client/mir_toolkit/client_types.h (+1/-0)
include/client/mir_toolkit/mir_input_device.h (+68/-0)
include/core/mir_toolkit/mir_input_device_types.h (+2/-2)
include/platform/mir/input/input_sink.h (+34/-1)
include/platform/mir/input/touchscreen_settings.h (+5/-0)
include/test/mir_test_framework/fake_input_device.h (+9/-0)
src/client/mir_input_device_api.cpp (+35/-0)
src/client/symbols.map (+6/-0)
src/include/server/mir/input/seat.h (+5/-1)
src/platforms/evdev/libinput_device.cpp (+49/-4)
src/platforms/evdev/libinput_device.h (+3/-0)
src/server/graphics/nested/input_platform.cpp (+18/-2)
src/server/input/basic_seat.cpp (+132/-12)
src/server/input/basic_seat.h (+15/-7)
src/server/input/default_configuration.cpp (+1/-1)
src/server/input/default_input_device_hub.cpp (+9/-1)
src/server/input/default_input_device_hub.h (+2/-1)
src/server/input/seat_input_device_tracker.cpp (+8/-4)
src/server/input/seat_input_device_tracker.h (+11/-2)
src/server/scene/surface_stack.cpp (+1/-5)
tests/acceptance-tests/test_client_input.cpp (+207/-33)
tests/include/mir/test/doubles/mock_input_seat.h (+3/-1)
tests/include/mir/test/doubles/mock_input_sink.h (+1/-0)
tests/integration-tests/input/test_single_seat_setup.cpp (+47/-14)
tests/mir_test_framework/fake_input_device_impl.cpp (+76/-14)
tests/mir_test_framework/fake_input_device_impl.h (+14/-0)
tests/unit-tests/input/evdev/test_libinput_device.cpp (+181/-15)
tests/unit-tests/input/test_seat_input_device_tracker.cpp (+1/-4)
tests/unit-tests/scene/test_surface_stack.cpp (+2/-2)
Changed in mir: | |
importance: | Undecided → High |
status: | New → Triaged |
tags: | added: input |
tags: | added: rotation |
Changed in mir: | |
assignee: | nobody → Andreas Pokorny (andreas-pokorny) |
milestone: | none → 1.0.0 |
status: | Triaged → In Progress |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
is this true on android as well ? or just on mesa platforms ?