Mir

MirMotionEvent::pointer_coordinates is problematic

Bug #1311809 reported by Daniel d'Andrada
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Invalid
Medium
Unassigned

Bug Description

1 - It's badly named as it contains more than the coordinates of the pointer. It has also id, tool_type. So why not call it simply "pointers"?

2 - There's no way of telling which axis is defined/exists and which is not. E.g. some devices provide touch_major and touch_minor, some do not. Likewise for pressure, orientation, etc. So, if you have a device that does not give, say, pressure. How do you fill you pointer_coordinates[i].pressure? with zero? That's a lie as 0 is a valid pressure value. And then, when reading MotionEvent.pointer_coordinates values, how do you tell if a given value was really reported by the device or if it just has its default value set by Mir? android::PointerCoords, for instance, has a "bits" variable that you can check to see which axes are present/defined.

tags: added: clientapi
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Sounds like two distinct issues, but close enough I guess we could keep it as one bug... ?

See also: bug 1175362

Changed in mir:
importance: Undecided → Medium
tags: added: input
Changed in mir:
status: New → Triaged
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It appears MirMotionEvent no longer exists.

Changed in mir:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.