Mir

[regression] clang: 'mir::test::doubles::MockSurface::visible' hides overloaded virtual function [-Woverloaded-virtual]

Bug #1301135 reported by Daniel van Vugt on 2014-04-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Low
Daniel van Vugt
mir (Ubuntu)
Low
Unassigned

Bug Description

Clang says:

[ 88%] Building CXX object tests/unit-tests/CMakeFiles/mir_unit_tests.dir/scene/test_broadcasting_session_event_sink.cpp.o
In file included from /home/dan/bzr/mir/zoom/tests/unit-tests/scene/test_application_session.cpp:25:
/home/dan/bzr/mir/zoom/include/test/mir_test_doubles/mock_surface.h:52:18: warning:
      'mir::test::doubles::MockSurface::visible' hides overloaded virtual
      function [-Woverloaded-virtual]
    MOCK_METHOD0(visible, bool());
                 ^
/usr/include/gmock/gmock-generated-function-mockers.h:672:51: note: expanded
      from macro 'MOCK_METHOD0'
#define MOCK_METHOD0(m, ...) GMOCK_METHOD0_(, , , m, __VA_ARGS__)
                                                  ^
/usr/include/gmock/gmock-generated-function-mockers.h:354:37: note: expanded
      from macro 'GMOCK_METHOD0_'
  GMOCK_RESULT_(tn, __VA_ARGS__) ct Method( \
                                    ^
/home/dan/bzr/mir/zoom/src/server/scene/basic_surface.h:134:10: note: hidden
      overloaded virtual function 'mir::scene::BasicSurface::visible' declared
      here: different qualifiers (const vs none)
    bool visible() const;
         ^
[ 88%] Building CXX object tests/unit-tests/CMakeFiles/mir_unit_tests.dir/scene/test_default_focus_mechanism.cpp.o
[ 88%] Building CXX object tests/unit-tests/CMakeFiles/mir_unit_tests.dir/scene/test_gl_pixel_buffer.cpp.o
[ 89%] Building CXX object tests/unit-tests/CMakeFiles/mir_unit_tests.dir/scene/test_global_event_sender.cpp.o
In file included from /home/dan/bzr/mir/zoom/tests/unit-tests/scene/test_default_focus_mechanism.cpp:30:
/home/dan/bzr/mir/zoom/include/test/mir_test_doubles/mock_surface.h:52:18: warning:
      'mir::test::doubles::MockSurface::visible' hides overloaded virtual
      function [-Woverloaded-virtual]
    MOCK_METHOD0(visible, bool());
                 ^
/usr/include/gmock/gmock-generated-function-mockers.h:672:51: note: expanded
      from macro 'MOCK_METHOD0'
#define MOCK_METHOD0(m, ...) GMOCK_METHOD0_(, , , m, __VA_ARGS__)
                                                  ^
/usr/include/gmock/gmock-generated-function-mockers.h:354:37: note: expanded
      from macro 'GMOCK_METHOD0_'
  GMOCK_RESULT_(tn, __VA_ARGS__) ct Method( \
                                    ^
/home/dan/bzr/mir/zoom/src/server/scene/basic_surface.h:134:10: note: hidden
      overloaded virtual function 'mir::scene::BasicSurface::visible' declared
      here: different qualifiers (const vs none)
    bool visible() const;
         ^

Related branches

Changed in mir:
assignee: nobody → Daniel van Vugt (vanvugt)
status: Triaged → In Progress
Changed in mir:
milestone: 0.1.8 → 0.1.9
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :
Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown

Changed in mir:
status: Fix Committed → Fix Released
Changed in mir (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.1.9+14.10.20140430.1-0ubuntu1

---------------
mir (0.1.9+14.10.20140430.1-0ubuntu1) utopic; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.1.9 (https://launchpad.net/mir/+milestone/0.1.9)
    - mirclient ABI unchanged, still at 7. Clients do not need rebuilding.
    - mirserver ABI bumped to 19. Shells need rebuilding.
    - More libmirserver class changes and reorganization, including;
      . Moving things from shell:: to scene::
      . Rewriting/refactoring surface factories.
    - Added an id() to Renderable.
    - Scene/Renderer interfaces:
      . Scene is no longer responsible for its own iteration (no for_each
        any more). Instead you should iterate over the list returned by
        Scene::generate_renderable_list().
    - Bugs fixed:
      . Stale socket issue. (LP: #1285215)
      . Qt render gets blocked on EGLSwapBuffers. (LP: #1292306)
      . Lock order violated found in helgrind (potential deadlock).
        (LP: #1296544)
      . [regression] SwitchingBundle in framedropping mode can hang.
        (LP: #1306464)
      . [DPMS] Display backlight turns back on almost immediately after
        being turned off. (LP: #1231857)
      . Wrong frame is seen on wake up/resume/unlock. (LP: #1233564)
      . Nested platform is not testable (LP: #1299101)
      . [regression] mir_demo_server_shell crashes on display resume.
        (LP: #1308941)
      . Multi-threaded composition is actually mostly serialized by
        SurfaceStack::guard. (LP: #1234018)
      . Mirscreencast slows down compositing and makes it very jerky.
        (LP: #1280938)
      . Mirscreencast can cause clients to render faster than the screen
        refresh rate. (LP: #1294361)
      . Screen turns on when a new session/surface appears. (LP: #1297876)
      . mir-doc package is >56MB in size, expands to >100MB of files.
        (LP: #1304998)
      . [regression] Clang: 'mir::test::doubles::MockSurface::visible'
        hides overloaded virtual function [-Woverloaded-virtual].
        (LP: #1301135)
      . [regression] GLRenderer* unit tests have recently become noisy.
        (LP: #1308905)
      . FocusController::set_focus_to() no longer seems to raise a session
        to the top. (LP: #1302689)

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Wed, 30 Apr 2014 13:26:58 +0000

Changed in mir (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers