unity8 cpu spike after blank/unblank (nexus4)
Bug #1233870 reported by
Kevin DuBois
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
High
|
Kevin DuBois | ||
| The Ubuntu Power Consumption Project |
Fix Released
|
Undecided
|
Kevin DuBois | ||
| mir (Ubuntu) |
Fix Released
|
High
|
Kevin DuBois | ||
Bug Description
after blank/unblank on nexus4 unity8, the hwc thread that dispatches vsync notifications will spike the cpu to 100%. ricmm & kdub determined this was due to violating this part of the hwc api:
http://
Related branches
lp:~kdub/mir/deactive-notifications-when-display-off
- Ricardo Mendoza (community): Approve
- Alan Griffiths: Approve
- Daniel van Vugt: Needs Fixing
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 381 lines (+124/-59)12 files modifiedinclude/test/mir_test_doubles/mock_display_support_provider.h (+1/-1)
include/test/mir_test_doubles/mock_hwc_interface.h (+1/-1)
include/test/mir_test_doubles/stub_display_support_provider.h (+1/-1)
src/server/graphics/android/android_display.cpp (+2/-5)
src/server/graphics/android/display_support_provider.h (+3/-2)
src/server/graphics/android/fb_device.cpp (+2/-2)
src/server/graphics/android/fb_device.h (+1/-1)
src/server/graphics/android/hwc_common_device.cpp (+54/-32)
src/server/graphics/android/hwc_common_device.h (+5/-2)
src/server/graphics/android/hwc_device.h (+1/-1)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+45/-3)
tests/unit-tests/graphics/android/test_hwc_display.cpp (+8/-8)
- Mir development team: Pending requested
-
Diff: 1500 lines (+592/-171)39 files modifiedinclude/server/mir/default_server_configuration.h (+3/-0)
include/server/mir/frontend/connector_report.h (+22/-2)
include/server/mir/frontend/session_mediator.h (+7/-2)
include/server/mir/logging/connector_report.h (+56/-0)
include/test/mir_test_doubles/mock_display_support_provider.h (+1/-1)
include/test/mir_test_doubles/mock_hwc_interface.h (+1/-1)
include/test/mir_test_doubles/mock_rpc_report.h (+2/-0)
include/test/mir_test_doubles/stub_display_support_provider.h (+1/-1)
src/client/logging/rpc_report.cpp (+9/-0)
src/client/logging/rpc_report.h (+17/-15)
src/client/lttng/rpc_report.cpp (+4/-0)
src/client/lttng/rpc_report.h (+17/-15)
src/client/mir_connection.cpp (+20/-4)
src/client/rpc/mir_basic_rpc_channel.cpp (+14/-0)
src/client/rpc/mir_basic_rpc_channel.h (+2/-0)
src/client/rpc/mir_socket_rpc_channel.cpp (+38/-29)
src/client/rpc/null_rpc_report.cpp (+4/-0)
src/client/rpc/null_rpc_report.h (+17/-15)
src/client/rpc/rpc_report.h (+2/-0)
src/server/default_server_configuration.cpp (+28/-0)
src/server/frontend/default_configuration.cpp (+2/-3)
src/server/frontend/published_socket_connector.cpp (+40/-2)
src/server/frontend/published_socket_connector.h (+1/-1)
src/server/frontend/session_mediator.cpp (+33/-27)
src/server/graphics/android/android_display.cpp (+2/-2)
src/server/graphics/android/display_support_provider.h (+8/-2)
src/server/graphics/android/fb_device.cpp (+2/-2)
src/server/graphics/android/fb_device.h (+1/-1)
src/server/graphics/android/hwc_common_device.cpp (+46/-31)
src/server/graphics/android/hwc_common_device.h (+5/-2)
src/server/graphics/android/hwc_device.h (+1/-1)
src/server/logging/CMakeLists.txt (+1/-0)
src/server/logging/connector_report.cpp (+98/-0)
tests/mir_test_framework/testing_process_manager.cpp (+2/-0)
tests/unit-tests/client/test_client_mir_surface.cpp (+3/-0)
tests/unit-tests/frontend/test_published_socket_connector.cpp (+15/-5)
tests/unit-tests/frontend/test_session_mediator.cpp (+38/-0)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+25/-3)
tests/unit-tests/graphics/android/test_hwc_display.cpp (+4/-4)
| Changed in mir: | |
| status: | New → In Progress |
| Changed in ubuntu-power-consumption: | |
| status: | New → In Progress |
| assignee: | nobody → Kevin DuBois (kdub) |
| tags: | added: pm |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-power-consumption: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-touch rls-s-incoming |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #2 |
| Changed in mir (Ubuntu): | |
| status: | New → Fix Released |
| importance: | Undecided → High |
| assignee: | nobody → Kevin DuBois (kdub) |
| Changed in ubuntu-power-consumption: | |
| status: | Fix Committed → Fix Released |
| Changed in mir: | |
| milestone: | none → 0.0.13 |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #3 |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:~mir-team/mir/development-branch at revision None, scheduled for release in mir, milestone Unknown