Most tests are silently disabled if libumockdev-dev is missing

[Alan Griffiths]

Since -r 798, if umockdev is missing cmake "succeeds" but no tests are built by the resulting makefile.

If we're going to allow disabling test generation there should be an explicit option to request it.

[Daniel van Vugt (vanvugt)]

I don't think we need an explicit option to request tests disabled. Instead we just need to improve the CMakeLists to be smarter, and only disable those tests that need to be disabled.

[Daniel van Vugt (vanvugt)]

Further info:
https://code.launchpad.net/~raof/mir/prober-drm-device-probe/+merge/170765/comments/385188

[Alexandros Frantzis (afrantzis)]

The problem with tests being implicitly disabled because of missing dependencies, is that people probably won't notice. That's especially true if only a small portion of the tests doesn't run. Furthermore, running some, but not all, of the tests gives a false sense of correctness, regardless of whether it is done on purpose or not.

I think it makes sense for tests to be considered a subproject with its own additional dependencies, that either gets built or not as a whole. I prefer being explicit about this, since tests are such an important/core subproject for us. That is, assume that we always want to build the tests, unless being told otherwise explicitly.

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.0.6