[enhancement] Add support for single buffered clients
Bug #1194333 reported by
Daniel van Vugt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Triaged
|
Low
|
Unassigned | ||
| mir (Ubuntu) |
Triaged
|
Low
|
Unassigned | ||
Bug Description
Clients can't render single-buffered (direct front-buffer write access).
Related branches
lp:~vanvugt/mir/single-buffer
- Daniel van Vugt: Needs Fixing
- PS Jenkins bot (community): Approve (continuous-integration)
- Alexandros Frantzis (community): Abstain
-
Diff: 287 lines (+59/-22)4 files modifiedsrc/server/compositor/gl_renderer.cpp (+3/-0)
src/server/compositor/switching_bundle.cpp (+38/-4)
src/server/compositor/switching_bundle.h (+1/-1)
tests/unit-tests/compositor/test_switching_bundle.cpp (+17/-17)
lp:~afrantzis/mir/client-surface-buffering-mode
- Robert Carr (community): Approve
- Chris Halse Rogers: Needs Information
- PS Jenkins bot (community): Approve (continuous-integration)
- Kevin DuBois (community): Needs Information
- Daniel van Vugt: Needs Fixing
- Alan Griffiths: Approve
-
Diff: 499 lines (+233/-12)18 files modifiedinclude/client/mir_toolkit/mir_surface.h (+8/-0)
include/common/mir_toolkit/common.h (+7/-0)
include/server/mir/scene/surface_creation_parameters.h (+1/-0)
src/client/mir_surface.cpp (+2/-0)
src/client/mir_surface.h (+1/-0)
src/client/mir_surface_api.cpp (+6/-0)
src/client/symbols.map (+1/-0)
src/protobuf/mir_protobuf.proto (+4/-0)
src/server/frontend/session_mediator.cpp (+1/-0)
src/server/scene/surface_allocator.cpp (+10/-2)
src/server/scene/surface_creation_parameters.cpp (+1/-0)
tests/acceptance-tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/test_client_surface_buffering_mode.cpp (+133/-0)
tests/include/mir_test_doubles/null_display_sync_group.h (+19/-3)
tests/include/mir_test_doubles/stub_display.h (+13/-6)
tests/include/mir_test_framework/stub_server_platform_factory.h (+3/-0)
tests/mir_test_framework/stub_server_platform_factory.cpp (+13/-0)
tests/mir_test_framework/stubbed_graphics_platform.cpp (+9/-1)
| Changed in mir: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| summary: |
- Clients can't render single-buffered (direct front-buffer write access) + [enhancement] Add support for single buffered clients |
| tags: | added: enhancement |
Revision history for this message
| Chris Halse Rogers (raof) wrote | #1 |
| Changed in mir: | |
| status: | Triaged → Incomplete |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #2 |
| Changed in mir: | |
| status: | Incomplete → Triaged |
| Changed in mir: | |
| assignee: | nobody → Daniel van Vugt (vanvugt) |
| status: | Triaged → In Progress |
| milestone: | none → 0.1.10 |
| Changed in mir: | |
| status: | In Progress → Triaged |
| assignee: | Daniel van Vugt (vanvugt) → nobody |
| milestone: | 0.2.0 → none |
Revision history for this message
| Michał Sawicz (saviq) wrote | #3 |
| Changed in mir (Ubuntu): | |
| importance: | Undecided → Low |
| status: | New → Triaged |
To post a comment you must log in.
Is this something that we actually want to support? We can fake single-buffering, but practically we're always at least double-buffered.