Potential race condition: clients_trying_to_acquire accessed without locking in BufferSwapperMulti::force_requests_to_complete()
Bug #1191689 reported by
Daniel van Vugt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Medium
|
Daniel van Vugt | ||
Bug Description
This if statement looks like it should be protected by swapper_mutex ...
void mc::BufferSwapp
{
if (in_use_by_client == swapper_size - 1 && clients_
{
Related branches
lp:~vanvugt/mir/switch
- PS Jenkins bot (community): Approve (continuous-integration)
- Alan Griffiths: Approve
- Kevin DuBois (community): Abstain
- Alexandros Frantzis (community): Approve
-
Diff: 5340 lines (+1332/-3186)55 files modifieddebian/control (+2/-2)
debian/libmirserver1.install (+1/-1)
examples/buffer_render_target.cpp (+8/-0)
examples/buffer_render_target.h (+1/-0)
include/server/mir/compositor/back_buffer_strategy.h (+0/-47)
include/server/mir/compositor/buffer_allocation_strategy.h (+0/-63)
include/server/mir/compositor/buffer_stream_factory.h (+6/-6)
include/server/mir/compositor/buffer_stream_surfaces.h (+0/-1)
include/server/mir/compositor/buffer_swapper.h (+0/-131)
include/server/mir/compositor/buffer_swapper_exceptions.h (+0/-42)
include/server/mir/compositor/buffer_swapper_multi.h (+0/-66)
include/server/mir/compositor/buffer_swapper_spin.h (+0/-73)
include/server/mir/compositor/multi_acquisition_back_buffer_strategy.h (+0/-66)
include/server/mir/compositor/swapper_factory.h (+0/-55)
include/server/mir/default_server_configuration.h (+0/-2)
include/test/mir_test_doubles/mock_buffer_bundle.h (+2/-0)
include/test/mir_test_doubles/mock_swapper.h (+0/-66)
include/test/mir_test_doubles/mock_swapper_factory.h (+0/-47)
src/server/CMakeLists.txt (+1/-1)
src/server/compositor/CMakeLists.txt (+0/-5)
src/server/compositor/buffer_bundle.h (+2/-0)
src/server/compositor/buffer_stream_factory.cpp (+5/-5)
src/server/compositor/buffer_stream_surfaces.cpp (+4/-7)
src/server/compositor/buffer_swapper_multi.cpp (+0/-174)
src/server/compositor/buffer_swapper_spin.cpp (+0/-114)
src/server/compositor/multi_acquisition_back_buffer_strategy.cpp (+0/-119)
src/server/compositor/rw_lock.cpp (+0/-71)
src/server/compositor/rw_lock.h (+0/-88)
src/server/compositor/swapper_factory.cpp (+0/-118)
src/server/compositor/switching_bundle.cpp (+352/-51)
src/server/compositor/switching_bundle.h (+55/-11)
src/server/compositor/temporary_buffers.cpp (+16/-7)
src/server/compositor/temporary_buffers.h (+13/-2)
src/server/default_server_configuration.cpp (+1/-14)
tests/integration-tests/compositor/CMakeLists.txt (+0/-1)
tests/integration-tests/compositor/test_buffer_stream.cpp (+132/-130)
tests/integration-tests/compositor/test_stress_buffer_swapper.cpp (+0/-308)
tests/integration-tests/compositor/test_swapping_swappers.cpp (+3/-6)
tests/integration-tests/graphics/android/test_buffer_integration.cpp (+5/-6)
tests/integration-tests/graphics/android/test_internal_client.cpp (+1/-4)
tests/integration-tests/shell/test_session.cpp (+1/-0)
tests/integration-tests/shell/test_session_manager.cpp (+0/-1)
tests/integration-tests/test_surfaceloop.cpp (+8/-39)
tests/unit-tests/compositor/CMakeLists.txt (+0/-6)
tests/unit-tests/compositor/test_buffer_stream.cpp (+14/-2)
tests/unit-tests/compositor/test_buffer_swapper.cpp (+0/-156)
tests/unit-tests/compositor/test_buffer_swapper_double.cpp (+0/-207)
tests/unit-tests/compositor/test_buffer_swapper_spin_triple.cpp (+0/-213)
tests/unit-tests/compositor/test_buffer_swapper_triple.cpp (+0/-125)
tests/unit-tests/compositor/test_rw_lock.cpp (+0/-173)
tests/unit-tests/compositor/test_swapper_factory.cpp (+0/-221)
tests/unit-tests/compositor/test_switching_bundle.cpp (+688/-111)
tests/unit-tests/compositor/test_temporary_buffers.cpp (+9/-21)
tests/unit-tests/graphics/android/test_internal_client_interpreter.cpp (+0/-1)
tests/unit-tests/surfaces/test_surface_stack.cpp (+2/-0)
| summary: |
Potential race condition: clients_trying_to_acquire accessed without - mutual exclusion in :BufferSwapperMulti::force_requests_to_complete() + locking :BufferSwapperMulti::force_requests_to_complete() |
| summary: |
Potential race condition: clients_trying_to_acquire accessed without - locking :BufferSwapperMulti::force_requests_to_complete() + locking in BufferSwapperMulti::force_requests_to_complete() |
| Changed in mir: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #1 |
| Changed in mir: | |
| importance: | Medium → Undecided |
| Changed in mir: | |
| importance: | Undecided → Medium |
| Changed in mir: | |
| assignee: | nobody → Daniel van Vugt (vanvugt) |
| status: | Triaged → Fix Released |
To post a comment you must log in.
Importance could be quite high if the race happens at a critical time. Not sure yet.