Unaccelerated clients are distorted on Android, because stride is in pixels on Android but is bytes on GBM and Mir.
Bug #1116452 reported by
Kevin DuBois
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Medium
|
Daniel van Vugt | ||
Bug Description
Android and gbm just relay their (int) representation of stride to the clients for unaccelerated region rendering. On GBM, this information is in byte units, and on android, the information is given in pixel units.
We need a uniform way that we present stride to the clients. Byte units are a more normal way to represent stride, so android should convert its stride units before presenting them to the clients
Related branches
lp:~vanvugt/mir/fix-1116452
- Kevin DuBois (community): Approve
- Alexandros Frantzis (community): Approve
- Alan Griffiths: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 73 lines (+15/-4)5 files modifiedinclude/shared/mir/geometry/pixel_format.h (+6/-0)
src/client/android/android_client_buffer.cpp (+2/-1)
src/server/graphics/android/buffer.cpp (+2/-1)
tests/unit-tests/client/android/test_client_android_buffer.cpp (+3/-1)
tests/unit-tests/graphics/android/test_buffer.cpp (+2/-1)
| information type: | Proprietary → Public |
| Changed in mir: | |
| status: | New → Confirmed |
| Changed in mir: | |
| status: | Confirmed → Triaged |
| Changed in mir: | |
| assignee: | Kevin DuBois (kdub) → Daniel van Vugt (vanvugt) |
| status: | Triaged → In Progress |
| summary: |
- gbm returns byte unit stride, android returns pixel unit stride + Unaccelerated clients are distorted on Android, because stride is in + pixels on Android but is bytes on GBM and Mir. |
| Changed in mir: | |
| milestone: | none → 0.0.4 |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.0.4