Margin should be all Drawables' property.
Bug #1204286 reported by
Jakub Sękowski
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Millennium Duel |
Fix Released
|
Wishlist
|
Jakub Sękowski |
Bug Description
I suggest to add member "margin" and method "SetMargin" to Drawable class definition. Why only Boxes may have it?
Related branches
lp:~sequba/millenniumduel/widgets-margin
- Rafał Cieślak: Approve
-
Diff: 687 lines (+146/-129)20 files modifiedsrc/IBox.cpp (+5/-5)
src/IBox.hpp (+1/-7)
src/IDrawable.cpp (+38/-13)
src/IDrawable.hpp (+32/-14)
src/IOrderedContainer.cpp (+0/-2)
src/IOrderedContainer.hpp (+0/-7)
src/WButton.cpp (+3/-3)
src/WButton.hpp (+8/-5)
src/WFixed.cpp (+3/-3)
src/WFixed.hpp (+9/-5)
src/WHBox.cpp (+9/-10)
src/WHBox.hpp (+5/-4)
src/WImage.cpp (+2/-2)
src/WImage.hpp (+2/-3)
src/WLabel.cpp (+3/-5)
src/WLabel.hpp (+4/-3)
src/WLayeredView.cpp (+3/-16)
src/WLayeredView.hpp (+5/-8)
src/WVBox.cpp (+9/-10)
src/WVBox.hpp (+5/-4)
Changed in millenniumduel: | |
status: | New → Confirmed |
milestone: | none → 0.1 |
Changed in millenniumduel: | |
assignee: | nobody → Jakub Sękowski (sequba) |
Changed in millenniumduel: | |
status: | Confirmed → Triaged |
Changed in millenniumduel: | |
status: | In Progress → Fix Committed |
Changed in millenniumduel: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
You may find it much much more convenient to fix this bug once https:/ /code.launchpad .net/~rafalcies lak256/ millenniumduel/ cached- redrawing/ is merged (I'm going to send a MP asap).