"midori --help-execute" crashes

Bug #998597 reported by gue5t gue5t
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

With recent changes to some encoding names, the action name EncodingChineseSimplified, which is longer than the old longest action name, started causing the line, "gchar* padding = g_strndup (space, strlen (space) - strlen (name));" in main.c to try to allocate a negative amount of memory (which was interpreted as an unsigned integer, and led to a crash when said memory couldn't be allocated). The attached patch fixes this and makes the printing logic work regardless of what action names might be present in the future.

Tags: crash
Revision history for this message
gue5t gue5t (gue5t) wrote :
Revision history for this message
Cris Dywan (kalikiana) wrote :

Good catch!

Changed in midori:
status: New → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.